README.md

@@ -1,12 +1,11 @@
 # 42sh - A POSIX shell with a bad name
 
-42sh is a project aiming to implement a POSIX-compliant shell written in C with only the standard library.
+42sh is a shcool project aiming to implement a POSIX compliant shell in C.
-Source de is fully documented with the doxygen format so you can easily understand how the project works by exploring it. 
-
-> **Note** This is a school project, therefore it probably won't interest you if you are looking for something useful.
 
 ## Getting started
 
+TODO
+
 ### Build
 run this command:
     `autoreconf --force --verbose --install`
@@ -17,43 +16,27 @@ run this command:
 then:
     `make`
 
-#### Build with ASan
+#### asan
 run this command:
     `./configure CFLAGS='-std=c99 -Werror -Wall -Wextra -Wvla -g -fsanitize=address'`
-
 or for MacOS (Jean Here):
     `./configure CFLAGS='-std=c99 -Werror -Wall -Wextra -Wvla -I/opt/homebrew/include' LDFLAGS='-L/opt/homebrew/lib'`
 
 then:
     `make check`
 
-## Project status
-
-### Implemented features
-
-* **Command Execution:** `$PATH` search and binary execution (via `fork` and `execvp`) with error return code handling.
-* **Built-ins:** Native implementation of `echo`, `cd`, `exit`, `export`, `unset`, `set`, `.`, `true`, `false`, as well as loop management with `break` and `continue`.
-* **Control Structures:** * Conditions: `if / then / elif / else / fi`.
-    * Loops: `while`, `until` and `for`.
-* **Logical Operators:** Command chaining with `&&`, `||` and negation with `!`.
-* **Pipelines and Redirections:** * Full management of pipes `|` to connect the output of one process to the input of another.
-    * Single and multiple redirections: `>`, `<`, `>>`, `>&`, `<&`, `<>`.
-* **Variables Management:** Assignment, variable expansion, and special variables handling like `$?` (return code of the last command).
-* **Command Grouping:** Execution blocks `{ ... }` and subshells creation `( ... )`.
-* **Quoting:** Support for weak (`"`) and strong (`'`) quoting for special characters escaping.
-
-## Architecture
-
-The shell operates on a classic compilation/interpretation pipeline:
-
-1. **Lexer (Lexical Analysis):** Reads standard input (or script) character by character and generates a stream of "Tokens" (Words, Operators, Redirections).
-2. **Parser (Syntax Analysis):** Syntax analyzer that transforms the token stream into a complex Abstract Syntax Tree (AST). This module strictly manages the nesting of control structures and enforces the rigid grammar of the Shell Command Language.
-3. **Execution (AST Traversal):** The tree is traversed recursively. Redirections modify file descriptors (`dup2`), child processes are created (`fork`), and commands are executed.
-
-
 ## Authors
 
-- Guillem George
 - Matteo Flebus
 - Jean Herail
 - William Valenduc
+- Guillem George
+
+## Project status
+
+WIP
+
+## TODO
+
+# Autotools
+implement functions in all .c files to see if everything compiles.

src/Makefile.am

@@ -18,9 +18,9 @@ bin_PROGRAMS = 42sh
 		parser/libparser.a \
 		lexer/liblexer.a \
 		io_backend/libio_backend.a \
-		utils/libutils.a \
 		execution/libexecution.a \
-		expansion/libexpansion.a
+		expansion/libexpansion.a \
+		utils/libutils.a
 
 # ================ TESTS ================
 
@@ -36,13 +36,13 @@ check_PROGRAMS = testsuite
 
 testsuite_SOURCES = ../tests/unit/utils/utils_tests.c \
 					../tests/unit/expansion/parse_var.c \
+					../tests/unit/io_backend/io_backend.c \
 					../tests/unit/utils/args.c \
 					../tests/unit/utils/hash_map.c \
 					../tests/unit/utils/insert_into.c
 
 # ../tests/unit/lexer/lexer_tests.c 
 # ../tests/unit/expansion/expand.c 
-# ../tests/unit/io_backend/io_backend.c
 
 testsuite_CPPFLAGS = $(42sh_CPPFLAGS)
 

src/execution/execution.c

@@ -1,15 +1,18 @@
 #define _POSIX_C_SOURCE 200809L
 #include "execution.h"
 
+#include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <unistd.h>
 
 #include "../expansion/expansion.h"
+#include "../utils/ast/ast.h"
 #include "../utils/hash_map/hash_map.h"
-#include "../utils/vars/vars.h"
 
 // Refactored: delegates to helpers in execution_helpers.c
 #include "execution_helpers.h"
@@ -19,55 +22,25 @@ int execution(struct ast *ast, struct hash_map *vars)
     if (!ast)
         return 0;
 
-    int res;
     switch (ast->type)
     {
     case AST_VOID:
     case AST_END:
-        res = 0;
+        return 0;
-        break;
     case AST_CMD: {
         struct ast_command *command = ast_get_command(ast);
         if (!expand(command, vars))
             fprintf(stderr, "Error: Variable expansion failed\n");
 
-        res = exec_ast_command(command, vars);
+        return exec_ast_command(command, vars);
-        break;
     }
     case AST_IF:
-        res = exec_ast_if(ast_get_if(ast), vars);
+        return exec_ast_if(ast_get_if(ast), vars);
-        break;
     case AST_LIST:
-        res = exec_ast_list(ast_get_list(ast), vars);
+        return exec_ast_list(ast_get_list(ast), vars);
-        break;
     case AST_AND_OR:
-        res = exec_ast_and_or(ast_get_and_or(ast), vars);
+        return exec_ast_and_or(ast_get_and_or(ast), vars);
-        break;
-    case AST_LOOP:
-        res = exec_ast_loop(ast_get_loop(ast), vars);
-        break;
-    case AST_SUBSHELL:
-        res = exec_ast_subshell(ast_get_subshell(ast), vars);
-        break;
     default:
-        res = 127;
+        return 127;
-        break;
-    }
-
-    if (res == EXEC_SIGNAL_EXIT)
-    {
-        char *exit_val_str = get_var(vars, "EXIT_VALUE");
-        if (exit_val_str == NULL)
-        {
-            fprintf(
-                stderr,
-                "Internal error: could not retrieve return value from exit\n");
-            return 2;
-        }
-        return atoi(exit_val_str);
-    }
-    else
-    {
-        return res;
     }
 }

src/execution/execution_helpers.c

@@ -1,21 +1,21 @@
 #define _POSIX_C_SOURCE 200809L
 #include "execution_helpers.h"
 
+#include <errno.h>
 #include <fcntl.h>
-#include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/wait.h>
 #include <unistd.h>
 
+#include "../expansion/expansion.h"
+#include "../utils/ast/ast.h"
 #include "../utils/hash_map/hash_map.h"
 #include "../utils/lists/lists.h"
 #include "../utils/vars/vars.h"
 #include "execution.h"
 
-// === Static functions
-
 static int open_redir_file(const struct ast_redir *redir, int *flags, int *mode)
 {
     *mode = 0644;
@@ -123,36 +123,8 @@ static char **list_to_argv(struct list *command_list)
     return argv;
 }
 
-/*
- * @brief parses string and returns the represented (unsigned) number
- * @return the number contained by the string or -1 if number is invalid
- */
-static int atou(char *str)
-{
-    if (str == NULL || *str == '\0')
-        return -1;
-
-    int result = 0;
-    size_t i = 0;
-    while (str[i] != '\0')
-    {
-        if (str[i] < '0' || str[i] > '9')
-            return -1;
-
-        result *= 10;
-        result += str[i] - '0';
-        i++;
-    }
-
-    return result;
-}
-
 static int try_builtin(char **argv, struct hash_map *vars);
 
-static int builtin_break(char **argv);
-static int builtin_continue(char **argv);
-static int builtin_unset(char **argv, struct hash_map *vars);
-
 static int exec_assignment(struct list *assignment_list, struct hash_map *vars)
 {
     while (assignment_list != NULL)
@@ -165,18 +137,12 @@ static int exec_assignment(struct list *assignment_list, struct hash_map *vars)
         struct ast_assignment *assignment =
             ast_get_assignment(assignment_list->data);
 
-        if (assignment->global)
-        {
-            setenv(assignment->name, assignment->value, 1);
-        }
         set_var_copy(vars, assignment->name, assignment->value);
         assignment_list = assignment_list->next;
     }
     return 0;
 }
 
-// === Functions
-
 int exec_ast_command(struct ast_command *command, struct hash_map *vars)
 {
     exec_assignment(command->assignments, vars);
@@ -238,46 +204,10 @@ int exec_ast_if(struct ast_if *if_node, struct hash_map *vars)
     if (if_node == NULL)
         return 2;
     int cond = execution(if_node->condition, vars);
-    if (cond == EXEC_SIGNAL_BREAK || cond == EXEC_SIGNAL_CONTINUE
-        || cond == EXEC_SIGNAL_EXIT)
-        return cond;
     if (cond == 0)
-    {
+        return execution(if_node->then_clause, vars);
-        int r = execution(if_node->then_clause, vars);
-        return r;
-    }
     else
-    {
+        return execution(if_node->else_clause, vars);
-        int r = execution(if_node->else_clause, vars);
-        return r;
-    }
-}
-
-int exec_ast_subshell(struct ast_subshell *subshell_node,
-                      struct hash_map *vars)
-{
-    pid_t pid = fork();
-    if (pid < 0)
-    {
-        perror("fork");
-        return 1;
-    }
-
-    if (pid == 0)
-    {
-        int res = execution(subshell_node->child, vars);
-        _exit(res);
-    }
-
-    int status = 0;
-    waitpid(pid, &status, 0);
-
-    if (WIFEXITED(status))
-    {
-        return WEXITSTATUS(status);
-    }
-
-    return 1;
 }
 
 int exec_ast_list(struct ast_list *list_node, struct hash_map *vars)
@@ -288,14 +218,7 @@ int exec_ast_list(struct ast_list *list_node, struct hash_map *vars)
     {
         struct ast *child = (struct ast *)cur->data;
         if (!ast_is_void(child))
-        {
+            ret = execution(child, vars);
-            int child_ret = execution(child, vars);
-            if (child_ret == EXEC_SIGNAL_BREAK
-                || child_ret == EXEC_SIGNAL_CONTINUE
-                || child_ret == EXEC_SIGNAL_EXIT)
-                return child_ret;
-            ret = child_ret;
-        }
         cur = cur->next;
     }
     return ret;
@@ -304,25 +227,16 @@ int exec_ast_list(struct ast_list *list_node, struct hash_map *vars)
 int exec_ast_and_or(struct ast_and_or *ao_node, struct hash_map *vars)
 {
     int left_ret = execution(ao_node->left, vars);
-    if (left_ret == EXEC_SIGNAL_BREAK || left_ret == EXEC_SIGNAL_CONTINUE
-        || left_ret == EXEC_SIGNAL_EXIT)
-        return left_ret;
     if (ao_node->type == AST_AND_OR_TYPE_AND)
     {
         if (left_ret == 0)
-        {
+            return execution(ao_node->right, vars);
-            int right_ret = execution(ao_node->right, vars);
-            return right_ret;
-        }
         return left_ret;
     }
     else
     {
         if (left_ret != 0)
-        {
+            return execution(ao_node->right, vars);
-            int right_ret = execution(ao_node->right, vars);
-            return right_ret;
-        }
         return left_ret;
     }
 }
@@ -361,117 +275,21 @@ void unset_all_redir(struct list *redir_list)
     }
 }
 
-int exec_ast_loop(struct ast_loop *loop_node, struct hash_map *vars)
-{
-    int res = 0;
-    while (execution(loop_node->condition, vars) == 0)
-    {
-        res = execution(loop_node->body, vars);
-        if (res == EXEC_SIGNAL_BREAK)
-        {
-            res = 0;
-            break;
-        }
-        else if (res == EXEC_SIGNAL_CONTINUE)
-        {
-            res = 0;
-            continue;
-        }
-    }
-
-    return res;
-}
-
 // --- Builtins ---
 
-static void print_with_escapes(const char *str)
-{
-    while (*str)
-    {
-        if (*str == '\\')
-        {
-            str++;
-            if (*str == 'n')
-                putchar('\n');
-            else if (*str == 't')
-                putchar('\t');
-            else if (*str == '\\')
-                putchar('\\');
-            else if (*str == 'a')
-                putchar('\a');
-            else if (*str == 'b')
-                putchar('\b');
-            else if (*str == 'f')
-                putchar('\f');
-            else if (*str == 'r')
-                putchar('\r');
-            else if (*str == 'v')
-                putchar('\v');
-            else if (*str == 'c')
-                return; // stop printing
-            else
-            {
-                // unrecognized escape, print "\"" and the char
-                putchar('\\');
-                if (*str)
-                    putchar(*str);
-            }
-        }
-        else
-        {
-            putchar(*str);
-        }
-        str++;
-    }
-}
-
 static int builtin_echo(char **argv)
 {
     bool newline = true;
-    bool interpret_escapes = false;
     int i = 1;
 
-    // Parse options
+    if (argv[1] && strcmp(argv[1], "-n") == 0)
-    while (argv[i] && argv[i][0] == '-')
-    {
-        char *opt = argv[i] + 1; // skip "-"
-        bool valid_option = false;
-        while (*opt)
-        {
-            if (*opt == 'n')
     {
         newline = false;
-                valid_option = true;
-            }
-            else if (*opt == 'e')
-            {
-                interpret_escapes = true;
-                valid_option = true;
-            }
-            else if (*opt == 'E')
-            {
-                interpret_escapes = false;
-                valid_option = true;
-            }
-            else
-            {
-                // invalid option so euh treat as regular argument
-                valid_option = false;
-                break;
-            }
-            opt++;
-        }
-        if (!valid_option)
-            break; // stop parsing options
         i++;
     }
 
-    // Print arguments
     for (; argv[i]; i++)
     {
-        if (interpret_escapes)
-            print_with_escapes(argv[i]);
-        else
         printf("%s", argv[i]);
         if (argv[i + 1])
             printf(" ");
@@ -483,18 +301,6 @@ static int builtin_echo(char **argv)
     return 0;
 }
 
-static int builtin_break(char **argv)
-{
-    (void)argv;
-    return EXEC_SIGNAL_BREAK;
-}
-
-static int builtin_continue(char **argv)
-{
-    (void)argv;
-    return EXEC_SIGNAL_CONTINUE;
-}
-
 static int builtin_true(char **argv)
 {
     (void)argv;
@@ -507,21 +313,13 @@ static int builtin_false(char **argv)
     return 1;
 }
 
-static int builtin_exit(char **argv, struct hash_map *vars)
+static int builtin_exit(char **argv)
 {
     int exit_val = 0;
     if (argv[1])
-    {
+        exit_val = atoi(argv[1]);
-        exit_val = atou(argv[1]);
+    exit(exit_val);
-        if (exit_val == -1)
+    return exit_val;
-        {
-            fprintf(stderr, "exit: Illegal number %s\n", argv[1]);
-            return 2;
-        }
-    }
-
-    set_var_int(vars, "EXIT_VALUE", exit_val);
-    return EXEC_SIGNAL_EXIT;
 }
 
 static int builtin_cd(char **argv, struct hash_map *vars)
@@ -548,23 +346,6 @@ static int builtin_cd(char **argv, struct hash_map *vars)
     return 0;
 }
 
-static int builtin_unset(char **argv, struct hash_map *vars)
-{
-    if (!argv)
-        return 0;
-    for (int i = 1; argv[i]; i++)
-    {
-        const char *name = argv[i];
-        if (name == NULL || name[0] == '\0')
-            continue;
-        // remove from shell variables
-        hash_map_remove(vars, name);
-        // remove from environment variables
-        unsetenv(name);
-    }
-    return 0;
-}
-
 /**
  * @brief Tries to execute a builtin command if the command matches a builtin
  *
@@ -578,18 +359,12 @@ static int try_builtin(char **argv, struct hash_map *vars)
 
     if (strcmp(argv[0], "echo") == 0)
         return builtin_echo(argv);
-    if (strcmp(argv[0], "unset") == 0)
-        return builtin_unset(argv, vars);
     if (strcmp(argv[0], "true") == 0)
         return builtin_true(argv);
     if (strcmp(argv[0], "false") == 0)
         return builtin_false(argv);
-    if (strcmp(argv[0], "break") == 0)
-        return builtin_break(argv);
-    if (strcmp(argv[0], "continue") == 0)
-        return builtin_continue(argv);
     if (strcmp(argv[0], "exit") == 0)
-        return builtin_exit(argv, vars);
+        return builtin_exit(argv);
     if (strcmp(argv[0], "cd") == 0)
         return builtin_cd(argv, vars);
 

src/execution/execution_helpers.h

@@ -4,18 +4,10 @@
 #include "../utils/ast/ast.h"
 #include "../utils/hash_map/hash_map.h"
 
-// Special execution signals used internally to implement loop control
-#define EXEC_SIGNAL_CONTINUE (-2)
-#define EXEC_SIGNAL_BREAK (-3)
-#define EXEC_SIGNAL_EXIT (-4)
-
 int exec_ast_command(struct ast_command *command, struct hash_map *vars);
 int exec_ast_if(struct ast_if *if_node, struct hash_map *vars);
 int exec_ast_list(struct ast_list *list_node, struct hash_map *vars);
 int exec_ast_and_or(struct ast_and_or *ao_node, struct hash_map *vars);
-int exec_ast_loop(struct ast_loop *loop_node, struct hash_map *vars);
-int exec_ast_subshell(struct ast_subshell *subshell_node,
-                        struct hash_map *vars);
 
 void unset_all_redir(struct list *redir_list);
 #endif // EXECUTION_HELPERS_H

src/expansion/expansion.c

@@ -1,6 +1,4 @@
 #define _POSIX_C_SOURCE 200809L
-#include "expansion.h"
-
 #include <ctype.h>
 #include <stdbool.h>
 #include <stdio.h>
@@ -117,40 +115,6 @@ static bool expand_var(char **str, size_t pos, const struct hash_map *vars)
     return false;
 }
 
-size_t parse_subshell_str(char *str, char **res)
-{
-    size_t i = 1; // skip the '('
-    int paren_count = 1;
-
-    if (str[i] == ')')
-    {
-        // empty subshell
-        *res = NULL;
-        return 0;
-    }
-
-    while (str[i] != 0)
-    {
-        if (str[i] == '(')
-            paren_count++;
-        else if (str[i] == ')')
-        {
-            paren_count--;
-
-            if (paren_count == 0)
-            {
-                *res = strndup(str + 1, i - 1);
-                return i + 1;
-            }
-        }
-        i++;
-    }
-
-    // error: parenthesis not closed
-    *res = NULL;
-    return 0;
-}
-
 bool expand(struct ast_command *command, const struct hash_map *vars)
 {
     if (command == NULL)
@@ -158,42 +122,34 @@ bool expand(struct ast_command *command, const struct hash_map *vars)
 
     char *str;
     size_t len;
-    enum quote_state quotes;
+    bool in_quotes;
     struct list *l = command->command;
 
     while (l != NULL)
     {
-        quotes = NO_QUOTE;
+        in_quotes = false;
         str = (char *)l->data;
         len = strlen(str);
 
         for (size_t i = 0; str[i] != 0; i++)
         {
-            if (str[i] == '\'' || str[i] == '\"')
+            if (str[i] == '\'')
             {
-                if (quotes == NO_QUOTE)
+                // remove single quote
-                {
+                in_quotes = !in_quotes;
-                    quotes = (str[i] == '\'') ? SINGLE_QUOTE : DOUBLE_QUOTE;
-                }
-                else if ((quotes == SINGLE_QUOTE && str[i] == '\'')
-                         || (quotes == DOUBLE_QUOTE && str[i] == '\"'))
-                {
-                    quotes = NO_QUOTE;
-                }
-                else
-                {
-                    // inside the other quote type, do nothing
-                    continue;
-                }
-
-                // remove quote
                 memmove(str + i, str + i + 1, strlen(str + i + 1) + 1);
                 i--;
             }
-            else if (quotes == SINGLE_QUOTE)
+            else if (in_quotes)
             {
                 continue; // do nothing
             }
+            else if (str[i] == '\"')
+            {
+                // remove double quote
+                memmove(str + i, str + i + 1, strlen(str + i + 1) + 1);
+                i--;
+            }
             else if (str[i] == '$' && str[i + 1] != 0 && !isspace(str[i + 1]))
             {
                 // variable expansion
@@ -205,20 +161,21 @@ bool expand(struct ast_command *command, const struct hash_map *vars)
             }
         }
 
-        // if (quotes != NO_QUOTE)
+        if (in_quotes)
-        // {
+        {
-        //     // error: quote not closed
+            // error: quote not closed
-        //     fprintf(stderr, "Error: quote not closed in string: %s\n", str);
+            fprintf(stderr, "Error: quote not closed in string: %s\n", str);
-        //     return false;
+            return false;
-        // }
+        }
 
         if (len != strlen(str))
         {
             char *new_str = realloc(str, strlen(str) + 1);
             if (new_str == NULL)
+            {
                 // error: realloc fail
                 return false;
-
+            }
             l->data = new_str;
         }
 

src/expansion/expansion.h

@@ -7,13 +7,6 @@
 #include "../utils/ast/ast.h"
 #include "../utils/hash_map/hash_map.h"
 
-enum quote_state
-{
-    NO_QUOTE,
-    SINGLE_QUOTE,
-    DOUBLE_QUOTE
-};
-
 /**
  * Parse a variable from a string starting with '$'.
  * @param str The input string starting with '$'. It must start with '$'.
@@ -23,15 +16,6 @@ enum quote_state
  */
 size_t parse_var_name(char *str, char **res);
 
-/**
- * Parse a subshell string enclosed in parentheses.
- * @param str The input string starting with '('. It must start with '('.
- * @param res Pointer to a char pointer that will be set to the extracted
- * subshell string.
- * @return The number of characters processed in the input string.
- */
-size_t parse_subshell_str(char *str, char **res);
-
 /**
  * Expand variables in an AST command using the provided variable map.
  * @param command The AST command to expand.

src/lexer/lexer_utils.c

@@ -72,16 +72,6 @@ static void set_token_keyword(struct token *tok, char *begin, ssize_t size)
         tok->type = TOKEN_ELSE;
     else if (strncmp(begin, "elif", size) == 0 && size == 4)
         tok->type = TOKEN_ELIF;
-    else if (strncmp(begin, "for", size) == 0 && size == 3)
-        tok->type = TOKEN_FOR;
-    else if (strncmp(begin, "while", size) == 0 && size == 5)
-        tok->type = TOKEN_WHILE;
-    else if (strncmp(begin, "until", size) == 0 && size == 5)
-        tok->type = TOKEN_UNTIL;
-    else if (strncmp(begin, "do", size) == 0 && size == 2)
-        tok->type = TOKEN_DO;
-    else if (strncmp(begin, "done", size) == 0 && size == 4)
-        tok->type = TOKEN_DONE;
     else if (strncmp(begin, "export", size) == 0 && size == 6)
         tok->type = TOKEN_EXPORT;
 
@@ -257,17 +247,16 @@ struct token *new_token(char *begin, ssize_t size, struct token_info *info)
     return tok;
 }
 
-void destroy_lexer_context(struct lexer_context *ctx)
+void destroy_lexer_context(struct lexer_context **ctx)
 {
-    struct token *prev = ctx->previous_token;
+    if (ctx == NULL || *ctx == NULL)
-    struct token *cur = ctx->current_token;
-    if (ctx == NULL)
         return;
-    if (prev != NULL)
+    if ((*ctx)->previous_token != NULL)
-        free_token(&prev);
+        free((*ctx)->previous_token);
-    if (cur != NULL)
+    if ((*ctx)->current_token != NULL)
-        free_token(&cur);
+        free((*ctx)->current_token);
-    free(ctx);
+    free(*ctx);
+    *ctx = NULL;
 }
 
 void free_token(struct token **tok)
@@ -309,7 +298,7 @@ ssize_t len_op_sepchar(char *stream, ssize_t i)
         return 2;
 
     // AND
-    if (stream[i] == '&' && stream[i + 1] == '&')
+    if (stream[i] == '|' && stream[i + 1] == '|')
         return 2;
 
     // special chars

src/lexer/lexer_utils.h

@@ -16,7 +16,7 @@ struct lexer_context
 
 /* @brief: frees all fields of ctx and sets ctx to NULL.
  */
-void destroy_lexer_context(struct lexer_context *ctx);
+void destroy_lexer_context(struct lexer_context **ctx);
 
 enum lexing_mode
 {

src/main.c

@@ -7,9 +7,74 @@
 #include "lexer/lexer.h"
 #include "parser/parser.h"
 #include "utils/args/args.h"
-#include "utils/main_loop/main_loop.h"
 #include "utils/vars/vars.h"
 
+// === Error codes
+
+#define SUCCESS 0
+#define ERR_INPUT_PROCESSING 2
+#define ERR_MALLOC 3
+#define ERR_GENERIC 4
+
+// === Functions
+
+/* @brief: frees the hash map.
+ * @return: always ERR_INPUT_PROCESSING.
+ */
+static int err_input(struct hash_map **vars)
+{
+    hash_map_free(vars);
+    return ERR_INPUT_PROCESSING;
+}
+
+static int main_loop(struct lexer_context *ctx, struct args_options *options,
+                     struct hash_map *vars)
+{
+    int return_code = SUCCESS;
+    // init parser
+    if (!parser_init())
+    {
+        perror("parser initialization failed.");
+    }
+
+    // Retrieve and build first AST
+    struct ast *command_ast = get_ast(ctx);
+
+    if (options->pretty_print)
+    {
+        ast_print_dot(command_ast);
+    }
+
+    // Main parse-execute loop
+    while (command_ast != NULL && command_ast->type != AST_END)
+    {
+        if (command_ast->type != AST_VOID)
+        {
+            // Execute AST
+            return_code = execution(command_ast, vars);
+
+            // set $? variable
+            set_var_int(vars, "?", return_code);
+        }
+
+        ast_free(&command_ast);
+
+        // Retrieve and build next AST
+        command_ast = get_ast(ctx);
+    }
+
+    if (command_ast == NULL)
+        return err_input(&vars);
+
+    // === free
+
+    ast_free(&command_ast);
+    parser_close();
+    hash_map_free(&vars);
+
+    return return_code;
+}
+
 int main(int argc, char **argv)
 {
     struct hash_map *vars = vars_init();
@@ -25,7 +90,7 @@ int main(int argc, char **argv)
     if (return_code != 0)
     {
         print_usage(stderr, argv[0]);
-        return err_input(&vars, NULL);
+        return err_input(&vars);
     }
     // args_print(&options);
 
@@ -40,7 +105,7 @@ int main(int argc, char **argv)
     {
         fprintf(stderr,
                 "Error: Failed to configure IO Backend from arguments\n");
-        return err_input(&vars, NULL);
+        return err_input(&vars);
     }
 
     // Init IO Backend (with the context struct)
@@ -50,22 +115,13 @@ int main(int argc, char **argv)
         fprintf(stderr,
                 "Error: IO Backend initialization failed with code %d\n",
                 return_code);
-        return err_input(&vars, NULL);
+        return err_input(&vars);
     }
 
     // init lexer context
-    struct lexer_context *ctx = calloc(1, sizeof(struct lexer_context));
+    struct lexer_context ctx = { 0 };
 
-    // init parser
+    return_code = main_loop(&ctx, &options, vars);
-    if (!parser_init())
-    {
-        perror("parser initialization failed.");
-        return err_input(&vars, ctx);
-    }
-
-    return_code = main_loop(ctx, vars);
-
-    parser_close();
 
     return return_code;
 }

src/parser/grammar.c

@@ -101,13 +101,17 @@ static void add_first_redir(void)
     add_first(RULE_REDIRECTION, TOKEN_REDIR_RIGHT_PIPE);
 }
 
-// Adds only direct tokens to rules firsts into the firsts map
+// === Functions
-static void add_firsts_tokens(void)
+
+int grammar_init(void)
 {
-    // Redirection
+    // Initialize the firsts map
-    add_first_redir();
+    bool success = init_firsts_map();
-    // %RIP Matteo 30/01/2026
+    if (success != true)
-    // %RAX Guillem 30/01/2026 hehe
+        return false;
+
+    // Populate the firsts map
+    // TODO CHECK ORDER
 
     // If
     add_first(RULE_IF, TOKEN_IF);
@@ -123,7 +127,7 @@ static void add_firsts_tokens(void)
     add_first(RULE_WHILE, TOKEN_WHILE);
 
     // Until
-    add_first(RULE_UNTIL, TOKEN_UNTIL);
+    add_first(RULE_WHILE, TOKEN_UNTIL);
 
     // Case
     add_first(RULE_CASE, TOKEN_CASE);
@@ -132,57 +136,33 @@ static void add_firsts_tokens(void)
     add_first(RULE_CASE_ITEM, TOKEN_LEFT_PAREN);
     add_first(RULE_CASE_ITEM, TOKEN_WORD);
 
-    // Shell command
+    // Case clause
-    add_first(RULE_SHELL_COMMAND, TOKEN_LEFT_BRACKET);
+    add_firsts(RULE_CASE_CLAUSE, first(RULE_CASE_ITEM));
-    add_first(RULE_SHELL_COMMAND, TOKEN_LEFT_PAREN);
 
-    // Simple command
+    // Redirection
-    add_first(RULE_SIMPLE_COMMAND, TOKEN_WORD);
+    add_first_redir();
-    add_first(RULE_SIMPLE_COMMAND, TOKEN_EXPORT);
+    // %RIP Matteo 30/01/2026
+    // %RAX Guillem 30/01/2026 hehe
 
     // Element
     add_first(RULE_ELEMENT, TOKEN_WORD);
     add_first(RULE_ELEMENT, TOKEN_ASSIGNMENT_WORD);
-
-    // Prefix
-    add_first(RULE_PREFIX, TOKEN_ASSIGNMENT_WORD);
-
-    // Pipeline
-    add_first(RULE_PIPELINE, TOKEN_WORD);
-
-    // Compound list
-    add_first(RULE_COMPOUND_LIST, TOKEN_NEWLINE);
-
-    // Input
-    add_first(RULE_INPUT, TOKEN_NEWLINE);
-    add_first(RULE_INPUT, TOKEN_EOF);
-
-    // Funcdec
-    add_first(RULE_FUNCDEC, TOKEN_WORD);
-}
-
-// Adds only firsts that depend on other rules to the firsts map
-// WARNING order matters
-static void add_firsts_rec(void)
-{
-    // Case clause
-    add_firsts(RULE_CASE_CLAUSE, first(RULE_CASE_ITEM));
-
-    // Element
     add_firsts(RULE_ELEMENT, first(RULE_REDIRECTION));
 
     // Prefix
+    add_first(RULE_PREFIX, TOKEN_ASSIGNMENT_WORD);
     add_firsts(RULE_PREFIX, first(RULE_REDIRECTION));
 
     // Shell command
     add_firsts(RULE_SHELL_COMMAND, first(RULE_IF));
-    add_firsts(RULE_SHELL_COMMAND, first(RULE_FOR));
-    add_firsts(RULE_SHELL_COMMAND, first(RULE_WHILE));
-    add_firsts(RULE_SHELL_COMMAND, first(RULE_UNTIL));
-    add_firsts(RULE_SHELL_COMMAND, first(RULE_CASE));
 
     // Simple command
     add_firsts(RULE_SIMPLE_COMMAND, first(RULE_PREFIX));
+    add_first(RULE_SIMPLE_COMMAND, TOKEN_WORD);
+    add_first(RULE_SIMPLE_COMMAND, TOKEN_EXPORT);
+
+    // Funcdec
+    add_first(RULE_FUNCDEC, TOKEN_WORD);
 
     // Command
     add_firsts(RULE_COMMAND, first(RULE_SIMPLE_COMMAND));
@@ -190,33 +170,23 @@ static void add_firsts_rec(void)
     add_firsts(RULE_COMMAND, first(RULE_FUNCDEC));
 
     // Pipeline
+    add_first(RULE_PIPELINE, TOKEN_WORD);
     add_firsts(RULE_PIPELINE, first(RULE_COMMAND));
 
     // And Or
     add_firsts(RULE_AND_OR, first(RULE_PIPELINE));
 
     // Compound list
+    add_first(RULE_COMPOUND_LIST, TOKEN_NEWLINE);
     add_firsts(RULE_COMPOUND_LIST, first(RULE_AND_OR));
 
     // List
     add_firsts(RULE_LIST, first(RULE_AND_OR));
 
     // Input
+    add_first(RULE_INPUT, TOKEN_NEWLINE);
+    add_first(RULE_INPUT, TOKEN_EOF);
     add_firsts(RULE_INPUT, first(RULE_LIST));
-}
-
-// === Functions
-
-int grammar_init(void)
-{
-    // Initialize the firsts map
-    bool success = init_firsts_map();
-    if (success != true)
-        return false;
-
-    // Populate the firsts map
-    add_firsts_tokens();
-    add_firsts_rec();
 
     return true;
 }

src/parser/grammar_advanced.c

@@ -149,57 +149,14 @@ struct ast *parse_prefix(struct lexer_context *ctx)
     }
 }
 
+// TODO NOT IMPLEMENTED
 struct ast *parse_funcdec(struct lexer_context *ctx)
 {
-    struct token *token = PEEK_TOKEN();
+    (void)ctx;
-    struct ast *value = NULL;
+    perror("Error: usage of a not implemented function (parse_funcdec)");
-    char *func_name = NULL;
-
-    if (token->type != TOKEN_WORD)
-    {
     return NULL;
 }
 
-    // word -> func name
-    POP_TOKEN();
-    func_name = strdup(token->data);
-
-    // (
-    token = PEEK_TOKEN();
-    if (token->type != TOKEN_LEFT_PAREN)
-    {
-        free(func_name);
-        return NULL;
-    }
-    POP_TOKEN();
-
-    // )
-    token = PEEK_TOKEN();
-    if (token->type != TOKEN_RIGHT_PAREN)
-    {
-        free(func_name);
-        return NULL;
-    }
-    POP_TOKEN();
-    token = PEEK_TOKEN();
-
-    // { \n }
-    while (token->type == TOKEN_NEWLINE)
-    {
-        POP_TOKEN();
-        token = PEEK_TOKEN();
-    }
-
-    // shell_command -> value
-    value = parse_shell_command(ctx);
-    if (value == NULL)
-    {
-        free(func_name);
-        return NULL;
-    }
-    return ast_create_function(func_name, value);
-}
-
 struct ast *parse_for(struct lexer_context *ctx)
 {
     (void)ctx;
@@ -220,18 +177,18 @@ struct ast *parse_while(struct lexer_context *ctx)
     }
     POP_TOKEN();
 
-    return parse_loop(ctx, false);
+    return parse_loop(ctx, true);
 }
 
 struct ast *parse_until(struct lexer_context *ctx)
 {
     struct token *token = PEEK_TOKEN();
 
-    // 'until'
+    // 'while'
     if (token->type != TOKEN_UNTIL)
     {
         perror(
-            "Internal error: expected a TOKEN_UNTIL but got a different type");
+            "Internal error: expected a TOKEN_WHILE but got a different type");
         return NULL;
     }
     POP_TOKEN();

src/parser/grammar_advanced.h

@@ -26,7 +26,7 @@ struct ast *parse_prefix(struct lexer_context *ctx);
 
 /*
  * @brief parses a funcdec rule
- * @warning Work in progress
+ * @warning NOT IMPLEMENTED
  *
  * @code funcdec = WORD '(' ')' {'\n'} shell_command ;
  *
@@ -36,6 +36,7 @@ struct ast *parse_funcdec(struct lexer_context *ctx);
 
 /*
  * @brief parses a for rule
+ * @warning NOT IMPLEMENTED
  *
  * @code rule_for = 'for' WORD
  *                  ( [';'] | [ {'\n'} 'in' { WORD } ( ';' | '\n' ) ] )

src/parser/grammar_basic.c

@@ -223,6 +223,7 @@ struct ast *parse_command(struct lexer_context *ctx)
     {
         result = parse_shell_command(ctx);
     }
+    // WARNING funcdec seems to require a LL(2) parser
     else if (is_first(*token, RULE_FUNCDEC))
     {
         result = parse_funcdec(ctx);
@@ -372,45 +373,28 @@ struct ast *parse_shell_command(struct lexer_context *ctx)
     struct token *token = PEEK_TOKEN();
     struct ast *result = NULL;
 
-    // '{'
+    // Grouping
-    if (token->type == TOKEN_LEFT_BRACKET)
+    // '(' or '{'
+    if (token->type == TOKEN_LEFT_BRACKET || token->type == TOKEN_LEFT_PAREN)
     {
         POP_TOKEN();
         result = parse_compound_list(ctx);
         if (result == NULL)
             return NULL;
 
-        // '}'
+        // ')' or '}'
         token = PEEK_TOKEN();
-        if (token->type == TOKEN_LEFT_BRACKET)
+        if (token->type == TOKEN_LEFT_BRACKET
+            || token->type == TOKEN_LEFT_PAREN)
         {
             ast_free(&result);
-            perror("Syntax error: bracket mismatch");
+            perror("Syntax error: bracket/parenthesis mismatch");
             return NULL;
         }
 
         POP_TOKEN();
         return result;
     }
-    // '('
-    else if (token->type == TOKEN_LEFT_PAREN)
-    {
-        POP_TOKEN();
-        result = parse_compound_list(ctx);
-        if (result == NULL)
-            return NULL;
-
-        // ')'
-        token = PEEK_TOKEN();
-        if (token->type == TOKEN_LEFT_PAREN)
-        {
-            ast_free(&result);
-            perror("Syntax error: parenthesis mismatch");
-            return NULL;
-        }
-        POP_TOKEN();
-        return ast_create_subshell(result);
-    }
     else if (is_first(*token, RULE_IF))
     {
         return parse_if_rule(ctx);

src/utils/Makefile.am

@@ -20,10 +20,7 @@ libutils_a_SOURCES =  \
 	ast/ast_loop.c \
 	args/args.c \
 	vars/vars.c \
-	main_loop/main_loop.c \
+	ast/ast_assignment.c
-	ast/ast_assignment.c \
-	ast/ast_subshell.c \
-	ast/ast_function.c
 
 libutils_a_CPPFLAGS = -I$(top_srcdir)/src
 

src/utils/args/args.c

@@ -67,7 +67,7 @@ int args_handler(int argc, char **argv, struct args_options *options,
 {
     options->type = INPUT_UNDEFINED;
     options->input_source = NULL;
-    // options->pretty_print = false;
+    options->pretty_print = false;
     options->verbose = false;
 
     struct list *args_list = NULL;
@@ -76,11 +76,11 @@ int args_handler(int argc, char **argv, struct args_options *options,
 
     for (int i = 1; i < argc; i++)
     {
-        /* if (strcmp(argv[i], "--pretty-print") == 0)
+        if (strcmp(argv[i], "--pretty-print") == 0)
         {
             options->pretty_print = true;
-        } */
+        }
-        if (strcmp(argv[i], "--verbose") == 0)
+        else if (strcmp(argv[i], "--verbose") == 0)
         {
             options->verbose = true;
         }
@@ -138,7 +138,7 @@ void args_print(struct args_options *options)
                                               : "UNDEFINED");
     printf("Input source: %s\n",
            options->input_source ? options->input_source : "NULL");
-    // printf("Pretty print: %s\n", options->pretty_print ? "true" : "false");
+    printf("Pretty print: %s\n", options->pretty_print ? "true" : "false");
     printf("Verbose: %s\n", options->verbose ? "true" : "false");
 }
 
@@ -147,8 +147,7 @@ void print_usage(FILE *std, const char *program_name)
     fprintf(std, "Usage: %s [OPTIONS] [SCRIPT] [ARGUMENTS...]\n", program_name);
     fprintf(std, "Options:\n");
     fprintf(std, "  -c [SCRIPT]        Execute the given command string.\n");
-    // fprintf(std, "  --pretty-print     Enable pretty printing of
+    fprintf(std, "  --pretty-print     Enable pretty printing of outputs.\n");
-    // outputs.\n");
     fprintf(std, "  --verbose          Enable verbose mode.\n");
     fprintf(std,
             "If no SCRIPT is provided, input is read from standard input.\n");

src/utils/args/args.h

@@ -22,7 +22,7 @@ struct args_options
     /** Type of the input source */
     enum input_type type;
     /** Enable or disable pretty printing of outputs */
-    // bool pretty_print;
+    bool pretty_print;
     /** Enable or disable verbose mode */
     bool verbose;
 };

src/utils/ast/ast.c

@@ -11,7 +11,7 @@ void ast_free(struct ast **node)
 {
     if (node == NULL || *node == NULL)
     {
-        fprintf(stderr,
+        perror(
             "WARNING: Internal error: failed to free AST node (NULL argument)");
         return;
     }
@@ -42,25 +42,13 @@ void ast_free(struct ast **node)
     case AST_ASSIGNMENT:
         ast_free_assignment(ast_get_assignment(*node));
         break;
-    case AST_NEG:
-        ast_free_neg(ast_get_neg(*node));
-        break;
-    case AST_LOOP:
-        ast_free_loop(ast_get_loop(*node));
-        break;
-    case AST_FUNCTION:
-        ast_free_function(ast_get_function(*node));
-        break;
-    case AST_SUBSHELL:
-        ast_free_subshell(ast_get_subshell(*node));
-        break;
     case AST_VOID:
     case AST_END:
         break;
 
     default:
-        fprintf(stderr, "WARNING: Internal error:"
+        perror("WARNING: Internal error: failed to free an AST node (Unknown "
-                " failed to free an AST node (Unknown type)");
+               "type)");
         return;
     }
 
@@ -80,7 +68,7 @@ struct ast *ast_create(enum ast_type type, void *data)
     return node;
 }
 
-/* // TODO handle new types (AST_WORD, AST_PIPE, etc.)
+// TODO handle new types (AST_WORD, AST_PIPE, etc.)
 static void ast_print_dot_recursive(struct ast *node, FILE *out)
 {
     if (!node)
@@ -171,4 +159,3 @@ void ast_print_dot(struct ast *ast)
     fprintf(dot_pipe, "}\n");
     pclose(dot_pipe);
 }
- */

src/utils/ast/ast.h

@@ -6,7 +6,6 @@
 #include "ast_base.h"
 #include "ast_command.h"
 #include "ast_end.h"
-#include "ast_function.h"
 #include "ast_if.h"
 #include "ast_list.h"
 #include "ast_loop.h"
@@ -15,6 +14,10 @@
 #include "ast_redir.h"
 #include "ast_void.h"
 #include "ast_word.h"
-#include "ast_subshell.h"
+
+/**
+ * Prints the Graphviz DOT representation of the given AST to stdout.
+ */
+void ast_print_dot(struct ast *ast);
 
 #endif /* ! AST_H */

src/utils/ast/ast_base.h

@@ -17,9 +17,7 @@ enum ast_type
     AST_PIPE,
     AST_NEG,
     AST_LOOP,
-    AST_ASSIGNMENT,
+    AST_ASSIGNMENT
-    AST_FUNCTION,
-    AST_SUBSHELL
 };
 
 struct ast

src/utils/ast/ast_function.c

@@ -1,42 +0,0 @@
-#include "ast_function.h"
-
-#include <stdlib.h>
-#include <string.h>
-
-#include "ast_base.h"
-
-bool ast_is_function(struct ast *node)
-{
-    return node != NULL && node->type == AST_FUNCTION;
-}
-
-struct ast_function *ast_get_function(struct ast *node)
-{
-    if (!ast_is_function(node))
-        return NULL;
-    return (struct ast_function *)node->data;
-}
-
-struct ast *ast_create_function(char *name, struct ast *value)
-{
-    struct ast_function *function_data = malloc(sizeof(struct ast_function));
-    if (!function_data)
-        return NULL;
-
-    function_data->name = name;
-    function_data->value = value;
-
-    return ast_create(AST_FUNCTION, function_data);
-}
-
-void ast_free_function(struct ast_function *function_data)
-{
-    if (function_data)
-    {
-        free(function_data->name);
-        // WARNING: this ast will be stored in the function hashmap.
-        // thus, it will be freed from the hashmap.
-        // ast_free(&function_data->value);
-        free(function_data);
-    }
-}

src/utils/ast/ast_function.h

@@ -1,33 +0,0 @@
-#ifndef AST_FUNCTION_H
-#define AST_FUNCTION_H
-
-#include <stdbool.h>
-
-struct ast_function
-{
-    char *name;
-    struct ast *value;
-};
-
-/**
- * @brief: Checks if the given AST node is an ast_function
- */
-bool ast_is_function(struct ast *node);
-
-/**
- * @brief: Retrieves the function data from the given AST node.
- *         Assumes that the node is of type AST_function.
- */
-struct ast_function *ast_get_function(struct ast *node);
-
-/**
- * @brief: Creates a new AST node representing an AST_function
- * @warning: name must be already allocated.
- */
-struct ast *ast_create_function(char *name, struct ast *value);
-/*
- * @brief: frees the given ast_function and sets the pointer to NULL.
- */
-void ast_free_function(struct ast_function *function_data);
-
-#endif /* AST_FUNCTION_H */

src/utils/ast/ast_subshell.c

@@ -1,31 +0,0 @@
-#include "ast_subshell.h"
-
-bool ast_is_subshell(struct ast *node)
-{
-    return node != NULL && node->type == AST_SUBSHELL;
-}
-
-struct ast_subshell *ast_get_subshell(struct ast *node)
-{
-    if (ast_is_subshell(node))
-        return (struct ast_subshell *)node->data;
-    return NULL;
-}
-
-struct ast *ast_create_subshell(struct ast *child)
-{
-    struct ast_subshell *subshell = calloc(1, sizeof(struct ast_subshell));
-    if (subshell == NULL)
-        return NULL;
-    subshell->child = child;
-
-    return ast_create(AST_SUBSHELL, subshell);
-}
-
-void ast_free_subshell(struct ast_subshell *subshell)
-{
-    if (!subshell)
-        return;
-    ast_free(&subshell->child);
-    free(subshell);
-}

src/utils/ast/ast_subshell.h

@@ -1,19 +0,0 @@
-#ifndef AST_SUBSHELL_H
-#define AST_SUBSHELL_H
-
-#include "ast_base.h"
-
-struct ast_subshell
-{
-    struct ast *child;
-};
-
-bool ast_is_subshell(struct ast *node);
-
-struct ast_subshell *ast_get_subshell(struct ast *node);
-
-struct ast *ast_create_subshell(struct ast *child);
-
-void ast_free_subshell(struct ast_subshell *subshell);
-
-#endif /* ! AST_SUBSHELL_H */

src/utils/hash_map/hash_map.c

@@ -7,8 +7,6 @@
 #include <stdlib.h>
 #include <string.h>
 
-#include "../ast/ast.h"
-
 /*
 ** Hash the key using FNV-1a 32 bits hash algorithm.
 */
@@ -38,14 +36,6 @@ static void destroy_pair_list(struct pair_list **p)
     *p = NULL;
 }
 
-static void destroy_pair_list_ast(struct pair_list **p)
-{
-    free((char *)(*p)->key);
-    ast_free((*p)->value);
-    free((*p));
-    *p = NULL;
-}
-
 struct hash_map *hash_map_init(size_t size)
 {
     struct hash_map *p = malloc(sizeof(struct hash_map));
@@ -126,32 +116,9 @@ void hash_map_free(struct hash_map **hash_map)
         }
         free((*hash_map)->data);
         free(*hash_map);
+    }
     *hash_map = NULL;
 }
-}
-
-void hash_map_free_ast(struct hash_map **hash_map)
-{
-    struct pair_list *l;
-    struct pair_list *prev;
-
-    if (hash_map != NULL && *hash_map != NULL)
-    {
-        for (size_t i = 0; i < (*hash_map)->size; i++)
-        {
-            l = (*hash_map)->data[i];
-            while (l != NULL)
-            {
-                prev = l;
-                l = l->next;
-                destroy_pair_list_ast(&prev);
-            }
-        }
-        free((*hash_map)->data);
-        free(*hash_map);
-        *hash_map = NULL;
-    }
-}
 
 void hash_map_foreach(struct hash_map *hash_map,
                       void (*fn)(const char *, const void *))

src/utils/main_loop/main_loop.c

@@ -1,111 +0,0 @@
-#define _POSIX_C_SOURCE 200809L
-
-#include "main_loop.h"
-
-// === Includes
-#include <stdio.h>
-#include <string.h>
-#include <stdlib.h>
-#include <unistd.h>
-#include <sys/types.h>
-#include <sys/wait.h>
-
-#include "../../execution/execution.h"
-#include "../../io_backend/io_backend.h"
-#include "../../lexer/lexer.h"
-#include "../../parser/parser.h"
-#include "../args/args.h"
-#include "../vars/vars.h"
-
-// === Functions
-
-int err_input(struct hash_map **vars, struct lexer_context *ctx)
-{
-    hash_map_free(vars);
-    destroy_lexer_context(ctx);
-    return ERR_INPUT_PROCESSING;
-}
-
-int main_loop(struct lexer_context *ctx, struct hash_map *vars)
-{
-    int return_code = SUCCESS;
-
-    // Retrieve and build first AST
-    struct ast *command_ast = get_ast(ctx);
-
-    // Main parse-execute loop
-    while (command_ast != NULL && command_ast->type != AST_END)
-    {
-        if (command_ast->type != AST_VOID)
-        {
-            // Execute AST
-            return_code = execution(command_ast, vars);
-
-            // set $? variable
-            set_var_int(vars, "?", return_code);
-        }
-
-        ast_free(&command_ast);
-
-        // Retrieve and build next AST
-        command_ast = get_ast(ctx);
-    }
-
-    if (command_ast == NULL)
-        return err_input(&vars, ctx);
-
-    // === free
-
-    ast_free(&command_ast);
-    hash_map_free(&vars);
-    destroy_lexer_context(ctx);
-
-    return return_code;
-}
-
-/* @brief: initializes a lexer context from a command string.
- * @return: pointer to the lexer context, or NULL on failure.
- */
-static struct lexer_context *lexer_init_from_string(char *command)
-{
-    // Create a lexer context from the command string
-    struct lexer_context *ctx = calloc(1, sizeof(struct lexer_context));
-    if (ctx == NULL)
-        return NULL;
-
-    ctx->end_previous_token = strdup(command);
-    if (ctx->end_previous_token == NULL)
-    {
-        free(ctx);
-        return NULL;
-    }
-    ctx->remaining_chars = strlen(command);
-
-    return ctx;
-}
-
-int start_subshell(struct hash_map **parent_vars, char *command)
-{
-    int fd = fork();
-    if (fd < 0)
-        return ERR_GENERIC;
-
-    else if (fd == 0) // Child process
-    {
-        struct lexer_context *ctx = lexer_init_from_string(command);
-        if (ctx == NULL)
-            return ERR_MALLOC;
-        int return_code = main_loop(ctx, *parent_vars);
-        exit(return_code);
-    }
-    else // Parent process
-    {
-        int status;
-        if (waitpid(fd, &status, 0) == -1)
-            return ERR_GENERIC;
-        if (WIFEXITED(status))
-            return WEXITSTATUS(status);
-        else
-            return ERR_GENERIC;
-    }
-}

src/utils/main_loop/main_loop.h

@@ -1,31 +0,0 @@
-#ifndef MAIN_LOOP_H
-#define MAIN_LOOP_H
-
-#include "../../utils/vars/vars.h"
-#include "../../lexer/lexer.h"
-
-// === Error codes
-#define SUCCESS 0
-#define ERR_INPUT_PROCESSING 2
-#define ERR_MALLOC 3
-#define ERR_GENERIC 4
-
-/* @brief: main loop called from main.
- * @return: exit code.
- */
-int main_loop(struct lexer_context *ctx, struct hash_map *vars);
-
-/*
- * @brief: frees the hash map and lexer context.
- * @return: ERR_INPUT_PROCESSING.
- */
-int err_input(struct hash_map **vars, struct lexer_context *ctx);
-
-/*
- * @brief: starts a subshell and builds the intern lexer context
- * from the string.
- * @return: exit code of the subshell.
- */
-int start_subshell(struct hash_map **parent_vars, char *command);
-
-#endif /* MAIN_LOOP_H */

tests/functional/func.sh

@@ -1,21 +0,0 @@
-func()
-{
-    echo hello
-}
-
-arg_func()
-{
-    echo first argument is "$1"
-}
-
-func_in_func()
-{
-    func
-}
-
-func_one_line() { echo "this is on one line"; }
-
-func
-arg_func "HERE"
-func_in_func
-func_one_line

tests/functional/loops.sh

@@ -1,20 +0,0 @@
-echo "starting tests"
-
-while false;
-do
-    echo "should NOT be printed"
-done
-
-a='yes'
-while [ "$a" -eq "yes" ];
-do
-    a="no"
-    echo "should be printed only once"
-done;
-
-while true;
-do
-    echo "yes"
-done;
-
-echo "tests done"

tests/functional/run-tests.sh

@@ -269,6 +269,9 @@ echo -e "\n\n""===$BGreen TestsuitatorX Ultra Pro Max+ 365 Premium Gris Sidéral
 
 
 
+
+#
+
 echo -e "\n$BBlue=== Builtins ===$Color_Off"
 # echo
 test_str "Hello" "echo Hello"
@@ -374,14 +377,9 @@ test_str "If with negation" "if ! false; then echo Yes; fi"
 test_str "If faut aller niquer sa mere" "if false; ! false; then echo Embrasse moi; fi"
 
 
-echo -e "\n$BBlue=== Loops ===$Color_Off"
+echo -e "\n$BBlue=== For/While ===$Color_Off"
-test_str "While false" "while false; do false; done"
+test_str "While loop" "i=0; while [ \$i -lt 3 ]; do echo \$i; i=\$((i+1)); done"
-test_str "While(false) true" "while false; do true; done"
+test_str "Until loop" "i=0; until [ \$i -ge 3 ]; do echo \$i; i=\$((i+1)); done"
-test_str "Until(true) false" "until true; do false; done"
-test_str "Until true" "until true; do true; done"
-# test_str "While var" "a=2; while [ \$a -eq 2 ]; do \$a=3; done"
-test_str "While arithmetic" "i=0; while [ \$i -lt 3 ]; do echo \$i; i=\$((i+1)); done"
-test_str "Until arithmetic" "i=0; until [ \$i -ge 3 ]; do echo \$i; i=\$((i+1)); done"
 test_str "While break" "while true; do echo break; break; done"
 test_str "While continue" "i=0; while [ \$i -lt 3 ]; do i=\$((i+1)); if [ \$i -eq 2 ]; then continue; fi; echo \$i; done"
 test_str "For loop basic" "for i in a b c; do echo \$i; done"

tests/unit/expansion/expand.c

@@ -1,6 +1,7 @@
 #define _POSIX_C_SOURCE 200809L
 #include <criterion/criterion.h>
 #include <criterion/new/assert.h>
+#include <criterion/redirect.h>
 #include <stdlib.h>
 #include <unistd.h>
 
@@ -16,7 +17,7 @@ Test(expand, no_expansion)
     char str[] = "echo something";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     bool ret = expand(ast_command, NULL);
@@ -31,7 +32,7 @@ Test(expand, single_quotes_no_expansion)
     char str[] = "echo '$VAR'";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -50,7 +51,7 @@ Test(expand, single_dollar)
     char str[] = "echo $ sign";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -69,7 +70,7 @@ Test(expand, empty_braces_no_expansion)
     char str[] = "echo ${}";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -86,7 +87,7 @@ Test(expand, basic_expansion)
     char str[] = "echo $VAR";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -105,7 +106,7 @@ Test(expand, multiple_expansion)
     char str[] = "echo $VAR1 $VAR2 ${VAR3}";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -127,7 +128,7 @@ Test(expand, env_variable)
     char str[] = "echo $MY_ENV_VAR";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     setenv("MY_ENV_VAR", "environment", 0);
@@ -144,7 +145,7 @@ Test(expand, undefined_variable)
     char str[] = "echo $UNDEFINED";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -162,7 +163,7 @@ Test(expand, nested_expansion)
     char str[] = "echo $B";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -177,34 +178,34 @@ Test(expand, nested_expansion)
     hash_map_free(&vars);
 }
 
-// Test(expand, mixed_quotes_expansion)
+Test(expand, mixed_quotes_expansion)
-// {
+{
-//     char str[] = "echo \"$VAR1 and '$VAR2'\"";
+    char str[] = "echo \"$VAR1 and '$VAR2'\"";
-//     char *str_heap = strdup(str);
+    char *str_heap = strdup(str);
-//     struct list *list = list_append(NULL, str_heap);
+    struct list *list = list_append(NULL, str_heap);
-//     struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
-//     struct ast_command *ast_command = ast_get_command(ast);
+    struct ast_command *ast_command = ast_get_command(ast);
 
-//     struct hash_map *vars = vars_init();
+    struct hash_map *vars = vars_init();
-//     set_var_copy(vars, "VAR1", "expanded");
+    set_var_copy(vars, "VAR1", "expanded");
-//     set_var_copy(vars, "VAR2", "not_expanded");
+    set_var_copy(vars, "VAR2", "not_expanded");
 
-//     bool ret = expand(ast_command, vars);
+    bool ret = expand(ast_command, vars);
-//     cr_expect(ret, "expansion failed with %s", str);
+    cr_expect(ret, "expansion failed with %s", str);
-//     cr_expect_str_eq((char *)ast_command->command->data,
+    cr_expect_str_eq((char *)ast_command->command->data,
-//                      "echo \"expanded and $VAR2\"",
+                     "echo \"expanded and $VAR2\"",
-//                      "Variable in double quotes should expand, while variable "
+                     "Variable in double quotes should expand, while variable "
-//                      "in single quotes should not");
+                     "in single quotes should not");
-//     ast_free(&ast);
+    ast_free(&ast);
-//     hash_map_free(&vars);
+    hash_map_free(&vars);
-// }
+}
 
 Test(expand, adjacent_variables)
 {
     char str[] = "echo $VAR1$VAR2";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -224,7 +225,7 @@ Test(expand, random)
     char str[] = "$RANDOM";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     bool ret = expand(ast_command, NULL);
@@ -240,7 +241,7 @@ Test(expand, pid)
     char str[] = "$$";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -258,7 +259,7 @@ Test(expand, default_last_exit_code)
     char str[] = "$?";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list, NULL, NULL);
+    struct ast *ast = ast_create_command(list);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();

tests/unit/expansion/parse_subshell.c

@@ -1,72 +0,0 @@
-#include <criterion/criterion.h>
-#include <criterion/new/assert.h>
-
-#include "../../../src/expansion/expansion.h"
-
-TestSuite(parse_subshell_str);
-
-Test(parse_subshell_str, basic_subshell)
-{
-    char *input = "(ls -l)";
-    char *extracted_var = NULL;
-    size_t r = parse_subshell_str(input, &extracted_var);
-
-    cr_expect(r == 7);
-    cr_expect_str_eq(extracted_var, "ls -l");
-    free(extracted_var);
-}
-
-Test(parse_subshell_str, multi_basic_subshell)
-{
-    char *input = "(echo hello) and (echo world)";
-    char *extracted_var = NULL;
-    size_t r = parse_subshell_str(input, &extracted_var);
-
-    cr_expect(r == 12);
-    cr_expect_str_eq(extracted_var, "echo hello");
-    free(extracted_var);
-
-    input += r + 5; // skip " and "
-    r = parse_subshell_str(input, &extracted_var);
-
-    cr_expect(r == 12);
-    cr_expect_str_eq(extracted_var, "echo world");
-    free(extracted_var);
-}
-
-Test(parse_subshell_str, incomplete_braces)
-{
-    char *input = "(echo hello";
-    char *extracted_var = NULL;
-    size_t r = parse_subshell_str(input, &extracted_var);
-
-    cr_expect(r == 0);
-    cr_expect(extracted_var == NULL);
-}
-
-Test(parse_subshell_str, empty_braces)
-{
-    char *input = "()";
-    char *extracted_var = NULL;
-    size_t r = parse_subshell_str(input, &extracted_var);
-
-    cr_expect(r == 0);
-    cr_expect(extracted_var == NULL);
-}
-
-Test(parse_subshell_str, nested_subshell)
-{
-    char *input = "(echo (nested))";
-    char *extracted_var = NULL;
-    size_t r = parse_subshell_str(input, &extracted_var);
-
-    cr_expect(r == 15);
-    cr_expect_str_eq(extracted_var, "echo (nested)");
-    free(extracted_var);
-
-    char *nested = input + 6; // point to the nested subshell
-    r = parse_subshell_str(nested, &extracted_var);
-    cr_expect(r == 8);
-    cr_expect_str_eq(extracted_var, "nested");
-    free(extracted_var);
-}

tests/unit/expansion/parse_var.c

@@ -1,5 +1,6 @@
 #include <criterion/criterion.h>
 #include <criterion/new/assert.h>
+#include <criterion/redirect.h>
 
 #include "../../../src/expansion/expansion.h"
 

tests/unit/utils/args.c

@@ -19,7 +19,7 @@ Test(utils_args, basic_command)
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    // cr_expect(options.pretty_print == false);
+    cr_expect(options.pretty_print == false);
     cr_expect(options.verbose == false);
     cr_expect(options.type == INPUT_CMD);
     cr_expect(eq(options.input_source, "echo Hello, World!"));
@@ -30,16 +30,14 @@ Test(utils_args, basic_command_with_flags)
 {
     int argc = 5;
     struct args_options options;
-    /* char *input[] = { "program", "--pretty-print", "-c", "echo Hello,
+    char *input[] = { "program", "--pretty-print", "-c", "echo Hello, World!",
-       World!",
+                      "--verbose" };
-                      "--verbose" };*/
-    char *input[] = { "program", "-c", "echo Hello, World!", "--verbose" };
 
     struct hash_map *vars = vars_init();
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    // cr_expect(options.pretty_print == true);
+    cr_expect(options.pretty_print == true);
     cr_expect(options.verbose == true);
     cr_expect(options.type == INPUT_CMD);
     cr_expect(eq(options.input_source, "echo Hello, World!"));
@@ -56,7 +54,7 @@ Test(utils_args, basic_file_input)
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    // cr_expect(options.pretty_print == false);
+    cr_expect(options.pretty_print == false);
     cr_expect(options.verbose == false);
     cr_expect(options.type == INPUT_FILE);
     cr_expect(eq(options.input_source, "input.txt"));
@@ -67,15 +65,13 @@ Test(utils_args, basic_file_input_with_flags)
 {
     int argc = 4;
     struct args_options options;
-    // char *input[] = { "program", "--verbose", "input.txt", "--pretty-print"
+    char *input[] = { "program", "--verbose", "input.txt", "--pretty-print" };
-    // };
-    char *input[] = { "program", "--verbose", "input.txt" };
 
     struct hash_map *vars = vars_init();
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    // cr_expect(options.pretty_print == true);
+    cr_expect(options.pretty_print == true);
     cr_expect(options.verbose == true);
     cr_expect(options.type == INPUT_FILE);
     cr_expect(eq(options.input_source, "input.txt"));
@@ -92,7 +88,7 @@ Test(utils_args, basic_stdin_input)
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    // cr_expect(options.pretty_print == false);
+    cr_expect(options.pretty_print == false);
     cr_expect(options.verbose == false);
     cr_expect(options.type == INPUT_STDIN);
     cr_expect(options.input_source == NULL);
@@ -103,14 +99,13 @@ Test(utils_args, pretty_print_and_verbose_flags)
 {
     int argc = 3;
     struct args_options options;
-    // char *input[] = { "program", "--pretty-print", "--verbose" };
+    char *input[] = { "program", "--pretty-print", "--verbose" };
-    char *input[] = { "program", "--verbose" };
 
     struct hash_map *vars = vars_init();
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    // cr_expect(options.pretty_print == true);
+    cr_expect(options.pretty_print == true);
     cr_expect(options.verbose == true);
     cr_expect(options.type == INPUT_STDIN);
     cr_expect(options.input_source == NULL);

tests/unit/utils/vars.c

@@ -3,7 +3,6 @@
 
 #include <criterion/criterion.h>
 #include <criterion/new/assert.h>
-#include <criterion/redirect.h>
 #include <stdio.h>
 #include <unistd.h>