doc: Update README

This reverts commit ac77d79a60.

README.md

@@ -1,11 +1,12 @@
 # 42sh - A POSIX shell with a bad name
 
-42sh is a shcool project aiming to implement a POSIX compliant shell in C.
+42sh is a project aiming to implement a POSIX-compliant shell written in C with only the standard library.
+Source de is fully documented with the doxygen format so you can easily understand how the project works by exploring it. 
+
+> **Note** This is a school project, therefore it probably won't interest you if you are looking for something useful.
 
 ## Getting started
 
-TODO
-
 ### Build
 run this command:
     `autoreconf --force --verbose --install`
@@ -16,27 +17,43 @@ run this command:
 then:
     `make`
 
-#### asan
+#### Build with ASan
 run this command:
     `./configure CFLAGS='-std=c99 -Werror -Wall -Wextra -Wvla -g -fsanitize=address'`
+
 or for MacOS (Jean Here):
     `./configure CFLAGS='-std=c99 -Werror -Wall -Wextra -Wvla -I/opt/homebrew/include' LDFLAGS='-L/opt/homebrew/lib'`
-
+    
 then:
     `make check`
 
+## Project status
+
+### Implemented features
+
+* **Command Execution:** `$PATH` search and binary execution (via `fork` and `execvp`) with error return code handling.
+* **Built-ins:** Native implementation of `echo`, `cd`, `exit`, `export`, `unset`, `set`, `.`, `true`, `false`, as well as loop management with `break` and `continue`.
+* **Control Structures:** * Conditions: `if / then / elif / else / fi`.
+    * Loops: `while`, `until` and `for`.
+* **Logical Operators:** Command chaining with `&&`, `||` and negation with `!`.
+* **Pipelines and Redirections:** * Full management of pipes `|` to connect the output of one process to the input of another.
+    * Single and multiple redirections: `>`, `<`, `>>`, `>&`, `<&`, `<>`.
+* **Variables Management:** Assignment, variable expansion, and special variables handling like `$?` (return code of the last command).
+* **Command Grouping:** Execution blocks `{ ... }` and subshells creation `( ... )`.
+* **Quoting:** Support for weak (`"`) and strong (`'`) quoting for special characters escaping.
+
+## Architecture
+
+The shell operates on a classic compilation/interpretation pipeline:
+
+1. **Lexer (Lexical Analysis):** Reads standard input (or script) character by character and generates a stream of "Tokens" (Words, Operators, Redirections).
+2. **Parser (Syntax Analysis):** Syntax analyzer that transforms the token stream into a complex Abstract Syntax Tree (AST). This module strictly manages the nesting of control structures and enforces the rigid grammar of the Shell Command Language.
+3. **Execution (AST Traversal):** The tree is traversed recursively. Redirections modify file descriptors (`dup2`), child processes are created (`fork`), and commands are executed.
+
+
 ## Authors
 
+- Guillem George
 - Matteo Flebus
 - Jean Herail
 - William Valenduc
-- Guillem George
-
-## Project status
-
-WIP
-
-## TODO
-
-# Autotools
-implement functions in all .c files to see if everything compiles.

check_flemme.sh

@@ -32,7 +32,7 @@ run_cmd "Running autoreconf" autoreconf --force --verbose --install
 if [[ "$(uname)" == "Darwin" ]]; then
     run_cmd "Configuring for MacOS" ./configure CFLAGS='-std=c99 -Werror -Wall -Wextra -Wvla -I/opt/homebrew/include' LDFLAGS='-L/opt/homebrew/lib'
 else
-    run_cmd "Configuring for Linux" ./configure CFLAGS='-std=c99 -Werror -Wall -Wextra -Wvla -g'
+    run_cmd "Configuring for Linux" ./configure CFLAGS='-std=c99 -Werror -Wall -Wextra -Wvla -g -fsanitize=address'
 fi
 
 run_cmd "Cleaning build" make clean

src/Makefile.am

@@ -18,9 +18,9 @@ bin_PROGRAMS = 42sh
 		parser/libparser.a \
 		lexer/liblexer.a \
 		io_backend/libio_backend.a \
+		utils/libutils.a \
 		execution/libexecution.a \
-		expansion/libexpansion.a \
-		utils/libutils.a
+		expansion/libexpansion.a
 
 # ================ TESTS ================
 
@@ -34,15 +34,16 @@ check_PROGRAMS = testsuite
 #testsuite_CFLAGS = $(42sh_CFLAGS)
 #testsuite_CFLAGS += $(CRITERION_CFLAGS)
 
-testsuite_SOURCES = ../tests/unit/lexer/lexer_tests.c \
-					../tests/unit/utils/utils_tests.c \
-					../tests/unit/expansion/expand.c \
+testsuite_SOURCES = ../tests/unit/utils/utils_tests.c \
 					../tests/unit/expansion/parse_var.c \
-					../tests/unit/io_backend/io_backend.c \
 					../tests/unit/utils/args.c \
 					../tests/unit/utils/hash_map.c \
 					../tests/unit/utils/insert_into.c
 
+# ../tests/unit/lexer/lexer_tests.c 
+# ../tests/unit/expansion/expand.c 
+# ../tests/unit/io_backend/io_backend.c
+
 testsuite_CPPFLAGS = $(42sh_CPPFLAGS)
 
 testsuite_LDADD = $(42sh_LDADD) -lcriterion

src/execution/execution.c

@@ -1,20 +1,15 @@
 #define _POSIX_C_SOURCE 200809L
 #include "execution.h"
 
-#include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
 #include <sys/types.h>
 #include <sys/wait.h>
 #include <unistd.h>
 
 #include "../expansion/expansion.h"
-#include "../utils/ast/ast.h"
 #include "../utils/hash_map/hash_map.h"
-
-
+#include "../utils/vars/vars.h"
 
 // Refactored: delegates to helpers in execution_helpers.c
 #include "execution_helpers.h"
@@ -24,26 +19,55 @@ int execution(struct ast *ast, struct hash_map *vars)
     if (!ast)
         return 0;
 
+    int res;
     switch (ast->type)
     {
     case AST_VOID:
     case AST_END:
-        return 0;
+        res = 0;
+        break;
     case AST_CMD: {
         struct ast_command *command = ast_get_command(ast);
         if (!expand(command, vars))
             fprintf(stderr, "Error: Variable expansion failed\n");
-        return exec_ast_command(command, vars);
+
+        res = exec_ast_command(command, vars);
+        break;
     }
     case AST_IF:
-        return exec_ast_if(ast_get_if(ast), vars);
+        res = exec_ast_if(ast_get_if(ast), vars);
+        break;
     case AST_LIST:
-        return exec_ast_list(ast_get_list(ast), vars);
+        res = exec_ast_list(ast_get_list(ast), vars);
+        break;
     case AST_AND_OR:
-        return exec_ast_and_or(ast_get_and_or(ast), vars);
-    case AST_REDIR:
-        return exec_ast_redir(ast_get_redir(ast), vars);
+        res = exec_ast_and_or(ast_get_and_or(ast), vars);
+        break;
+    case AST_LOOP:
+        res = exec_ast_loop(ast_get_loop(ast), vars);
+        break;
+    case AST_SUBSHELL:
+        res = exec_ast_subshell(ast_get_subshell(ast), vars);
+        break;
     default:
-        return 127;
+        res = 127;
+        break;
+    }
+
+    if (res == EXEC_SIGNAL_EXIT)
+    {
+        char *exit_val_str = get_var(vars, "EXIT_VALUE");
+        if (exit_val_str == NULL)
+        {
+            fprintf(
+                stderr,
+                "Internal error: could not retrieve return value from exit\n");
+            return 2;
+        }
+        return atoi(exit_val_str);
+    }
+    else
+    {
+        return res;
     }
 }

src/execution/execution_helpers.c

@@ -1,131 +1,20 @@
 #define _POSIX_C_SOURCE 200809L
 #include "execution_helpers.h"
 
-#include <errno.h>
 #include <fcntl.h>
+#include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/wait.h>
 #include <unistd.h>
 
-#include "../expansion/expansion.h"
-#include "../utils/ast/ast.h"
 #include "../utils/hash_map/hash_map.h"
+#include "../utils/lists/lists.h"
+#include "../utils/vars/vars.h"
 #include "execution.h"
 
-static char **list_to_argv(struct list *command_list)
-{
-    size_t len = 0;
-    struct list *cur = command_list;
-    while (cur)
-    {
-        len++;
-        cur = cur->next;
-    }
-    char **argv = calloc(len + 1, sizeof(char *));
-    if (!argv)
-        return NULL;
-    cur = command_list;
-    for (size_t i = 0; i < len; i++)
-    {
-        argv[i] = (char *)cur->data;
-        cur = cur->next;
-    }
-    argv[len] = NULL;
-    return argv;
-}
-
-static int try_builtin(char **argv);
-
-int exec_ast_command(struct ast_command *command, struct hash_map *vars)
-{
-    (void)vars;
-    if (!command || !(command->command))
-        return 1;
-    char **argv = list_to_argv(command->command);
-    if (!argv || !(argv[0]))
-    {
-        free(argv);
-        return 0;
-    }
-    int builtin_ret = try_builtin(argv);
-    if (builtin_ret != -1)
-    {
-        free(argv);
-        return builtin_ret;
-    }
-    pid_t pid = fork();
-    if (pid < 0)
-    {
-        perror("fork");
-        free(argv);
-        return 1;
-    }
-    if (pid == 0)
-    {
-        execvp(argv[0], argv);
-        perror("execvp");
-        _exit(127);
-    }
-    int status = 0;
-    waitpid(pid, &status, 0);
-    free(argv);
-    if (WIFEXITED(status))
-        return WEXITSTATUS(status);
-    return 1;
-}
-
-int exec_ast_if(struct ast_if *if_node, struct hash_map *vars)
-{
-    int cond = execution(if_node->condition, vars);
-    if (cond == 0)
-        return execution(if_node->then_clause, vars);
-    else
-        return execution(if_node->else_clause, vars);
-}
-
-int exec_ast_list(struct ast_list *list_node, struct hash_map *vars)
-{
-    struct list *cur = list_node->children;
-    int ret = 0;
-    while (cur)
-    {
-        struct ast *child = (struct ast *)cur->data;
-        if (!ast_is_void(child))
-            ret = execution(child, vars);
-        cur = cur->next;
-    }
-    return ret;
-}
-
-int exec_ast_and_or(struct ast_and_or *ao_node, struct hash_map *vars)
-{
-    int left_ret = execution(ao_node->left, vars);
-    if (ao_node->type == AST_AND_OR_TYPE_AND)
-    {
-        if (left_ret == 0)
-            return execution(ao_node->right, vars);
-        return left_ret;
-    }
-    else
-    {
-        if (left_ret != 0)
-            return execution(ao_node->right, vars);
-        return left_ret;
-    }
-}
-
-static int get_fd_target(const struct ast_redir *redir)
-{
-    if (redir->io_number != -1)
-        return redir->io_number;
-    if (redir->type == AST_REDIR_TYPE_LESS
-        || redir->type == AST_REDIR_TYPE_DLESS
-        || redir->type == AST_REDIR_TYPE_LESSAND)
-        return 0;
-    return 1;
-}
+// === Static functions
 
 static int open_redir_file(const struct ast_redir *redir, int *flags, int *mode)
 {
@@ -149,81 +38,441 @@ static int open_redir_file(const struct ast_redir *redir, int *flags, int *mode)
     return -3; // not a file open
 }
 
-static int handle_and_restore_fd(int saved_fd, int fd_target)
+static int set_all_redir(struct list *redir_list)
 {
-    if (saved_fd != -1)
+    while (redir_list)
     {
-        dup2(saved_fd, fd_target);
-        close(saved_fd);
-    }
-    else
-    {
-        close(fd_target);
+        struct ast *redir_node = (struct ast *)redir_list->data;
+        struct ast_redir *redir = ast_get_redir(redir_node);
+        int target_fd;
+        if (redir->io_number != -1)
+        {
+            target_fd = redir->io_number;
+        }
+        else
+        {
+            if (redir->type == AST_REDIR_TYPE_LESS
+                || redir->type == AST_REDIR_TYPE_LESSGREAT
+                || redir->type == AST_REDIR_TYPE_LESSAND)
+            {
+                target_fd = 0;
+            }
+            else
+            {
+                target_fd = 1;
+            }
+        }
+        redir->saved_fd = dup(target_fd);
+        int new_fd = -1;
+        int flags = 0;
+        int mode = 0644;
+        if (redir->type == AST_REDIR_TYPE_GREAT
+            || redir->type == AST_REDIR_TYPE_CLOBBER
+            || redir->type == AST_REDIR_TYPE_DGREAT
+            || redir->type == AST_REDIR_TYPE_LESS)
+        {
+            new_fd = open_redir_file(redir, &flags, &mode);
+            if (new_fd == -1)
+            {
+                perror("open");
+                return -1;
+            }
+        }
+        else if (redir->type == AST_REDIR_TYPE_GREATAND
+                 || redir->type == AST_REDIR_TYPE_LESSAND)
+        {
+            new_fd = atoi(redir->filename);
+        }
+        if (dup2(new_fd, target_fd) == -1)
+        {
+            perror("dup2");
+            if (new_fd != -1)
+            {
+                close(new_fd);
+            }
+            return -1;
+        }
+        if (new_fd != -1)
+        {
+            close(new_fd);
+        }
+        redir_list = redir_list->next;
     }
     return 0;
 }
 
-int exec_ast_redir(struct ast_redir *redir, struct hash_map *vars)
+static char **list_to_argv(struct list *command_list)
 {
-    int fd_target = get_fd_target(redir);
-    int saved_fd = dup(fd_target);
-    int new_fd = -1, flags = 0, mode = 0644;
-    if (redir->type == AST_REDIR_TYPE_GREAT
-        || redir->type == AST_REDIR_TYPE_CLOBBER
-        || redir->type == AST_REDIR_TYPE_DGREAT
-        || redir->type == AST_REDIR_TYPE_LESS)
+    size_t len = 0;
+    struct list *cur = command_list;
+    while (cur)
     {
-        new_fd = open_redir_file(redir, &flags, &mode);
-        if (new_fd == -1)
-        {
-            perror("open");
-            if (saved_fd != -1)
-                close(saved_fd);
-            return 1;
-        }
-        if (dup2(new_fd, fd_target) == -1)
-        {
-            perror("dup2");
-            close(new_fd);
-            if (saved_fd != -1)
-                close(saved_fd);
-            return 1;
-        }
-        close(new_fd);
+        len++;
+        cur = cur->next;
     }
-    else if (redir->type == AST_REDIR_TYPE_GREATAND
-             || redir->type == AST_REDIR_TYPE_LESSAND)
+    char **argv = calloc(len + 1, sizeof(char *));
+    if (!argv)
+        return NULL;
+    cur = command_list;
+    for (size_t i = 0; i < len; i++)
     {
-        new_fd = atoi(redir->filename);
-        if (dup2(new_fd, fd_target) == -1)
+        argv[i] = (char *)cur->data;
+        cur = cur->next;
+    }
+    argv[len] = NULL;
+    return argv;
+}
+
+/*
+ * @brief parses string and returns the represented (unsigned) number
+ * @return the number contained by the string or -1 if number is invalid
+ */
+static int atou(char *str)
+{
+    if (str == NULL || *str == '\0')
+        return -1;
+
+    int result = 0;
+    size_t i = 0;
+    while (str[i] != '\0')
+    {
+        if (str[i] < '0' || str[i] > '9')
+            return -1;
+
+        result *= 10;
+        result += str[i] - '0';
+        i++;
+    }
+
+    return result;
+}
+
+static int try_builtin(char **argv, struct hash_map *vars);
+
+static int builtin_break(char **argv);
+static int builtin_continue(char **argv);
+static int builtin_unset(char **argv, struct hash_map *vars);
+
+static int exec_assignment(struct list *assignment_list, struct hash_map *vars)
+{
+    while (assignment_list != NULL)
+    {
+        if (!ast_is_assignment(assignment_list->data))
         {
-            perror("dup2");
-            if (saved_fd != -1)
-                close(saved_fd);
+            fprintf(stderr, "list of assignements contains something else");
             return 1;
         }
+        struct ast_assignment *assignment =
+            ast_get_assignment(assignment_list->data);
+
+        if (assignment->global)
+        {
+            setenv(assignment->name, assignment->value, 1);
+        }
+        set_var_copy(vars, assignment->name, assignment->value);
+        assignment_list = assignment_list->next;
+    }
+    return 0;
+}
+
+// === Functions
+
+int exec_ast_command(struct ast_command *command, struct hash_map *vars)
+{
+    exec_assignment(command->assignments, vars);
+    set_all_redir(command->redirections);
+
+    if (!command || !(command->command))
+    {
+        return 1;
+    }
+
+    char **argv = list_to_argv(command->command);
+    if (!argv || !(argv[0]))
+    {
+        free(argv);
+        unset_all_redir(command->redirections);
+        return 0;
+    }
+
+    int builtin_ret = try_builtin(argv, vars);
+    if (builtin_ret != -1)
+    {
+        free(argv);
+        unset_all_redir(command->redirections);
+        return builtin_ret;
+    }
+
+    pid_t pid = fork();
+    if (pid < 0)
+    {
+        perror("fork");
+        free(argv);
+        unset_all_redir(command->redirections);
+        return 1;
+    }
+
+    if (pid == 0)
+    {
+        execvp(argv[0], argv);
+        perror("execvp");
+        unset_all_redir(command->redirections);
+        _exit(127);
+    }
+
+    int status = 0;
+    waitpid(pid, &status, 0);
+    free(argv);
+    unset_all_redir(command->redirections);
+
+    if (WIFEXITED(status))
+    {
+        return WEXITSTATUS(status);
+    }
+
+    return 1;
+}
+
+int exec_ast_if(struct ast_if *if_node, struct hash_map *vars)
+{
+    if (if_node == NULL)
+        return 2;
+    int cond = execution(if_node->condition, vars);
+    if (cond == EXEC_SIGNAL_BREAK || cond == EXEC_SIGNAL_CONTINUE
+        || cond == EXEC_SIGNAL_EXIT)
+        return cond;
+    if (cond == 0)
+    {
+        int r = execution(if_node->then_clause, vars);
+        return r;
+    }
+    else
+    {
+        int r = execution(if_node->else_clause, vars);
+        return r;
+    }
+}
+
+int exec_ast_subshell(struct ast_subshell *subshell_node,
+                      struct hash_map *vars)
+{
+    pid_t pid = fork();
+    if (pid < 0)
+    {
+        perror("fork");
+        return 1;
+    }
+
+    if (pid == 0)
+    {
+        int res = execution(subshell_node->child, vars);
+        _exit(res);
+    }
+
+    int status = 0;
+    waitpid(pid, &status, 0);
+
+    if (WIFEXITED(status))
+    {
+        return WEXITSTATUS(status);
+    }
+
+    return 1;
+}
+
+int exec_ast_list(struct ast_list *list_node, struct hash_map *vars)
+{
+    struct list *cur = list_node->children;
+    int ret = 0;
+    while (cur)
+    {
+        struct ast *child = (struct ast *)cur->data;
+        if (!ast_is_void(child))
+        {
+            int child_ret = execution(child, vars);
+            if (child_ret == EXEC_SIGNAL_BREAK
+                || child_ret == EXEC_SIGNAL_CONTINUE
+                || child_ret == EXEC_SIGNAL_EXIT)
+                return child_ret;
+            ret = child_ret;
+        }
+        cur = cur->next;
     }
-    int ret = execution(redir->child, vars);
-    handle_and_restore_fd(saved_fd, fd_target);
     return ret;
 }
 
+int exec_ast_and_or(struct ast_and_or *ao_node, struct hash_map *vars)
+{
+    int left_ret = execution(ao_node->left, vars);
+    if (left_ret == EXEC_SIGNAL_BREAK || left_ret == EXEC_SIGNAL_CONTINUE
+        || left_ret == EXEC_SIGNAL_EXIT)
+        return left_ret;
+    if (ao_node->type == AST_AND_OR_TYPE_AND)
+    {
+        if (left_ret == 0)
+        {
+            int right_ret = execution(ao_node->right, vars);
+            return right_ret;
+        }
+        return left_ret;
+    }
+    else
+    {
+        if (left_ret != 0)
+        {
+            int right_ret = execution(ao_node->right, vars);
+            return right_ret;
+        }
+        return left_ret;
+    }
+}
+
+void unset_all_redir(struct list *redir_list)
+{
+    while (redir_list)
+    {
+        struct ast *redir_node = (struct ast *)redir_list->data;
+        struct ast_redir *redir = ast_get_redir(redir_node);
+        int target_fd;
+        if (redir->io_number != -1)
+        {
+            target_fd = redir->io_number;
+        }
+        else
+        {
+            if (redir->type == AST_REDIR_TYPE_LESS
+                || redir->type == AST_REDIR_TYPE_LESSGREAT
+                || redir->type == AST_REDIR_TYPE_LESSAND)
+            {
+                target_fd = 0;
+            }
+            else
+            {
+                target_fd = 1;
+            }
+        }
+        if (redir->saved_fd != -1)
+        {
+            dup2(redir->saved_fd, target_fd);
+            close(redir->saved_fd);
+            redir->saved_fd = -1;
+        }
+        redir_list = redir_list->next;
+    }
+}
+
+int exec_ast_loop(struct ast_loop *loop_node, struct hash_map *vars)
+{
+    int res = 0;
+    while (execution(loop_node->condition, vars) == 0)
+    {
+        res = execution(loop_node->body, vars);
+        if (res == EXEC_SIGNAL_BREAK)
+        {
+            res = 0;
+            break;
+        }
+        else if (res == EXEC_SIGNAL_CONTINUE)
+        {
+            res = 0;
+            continue;
+        }
+    }
+
+    return res;
+}
+
 // --- Builtins ---
 
+static void print_with_escapes(const char *str)
+{
+    while (*str)
+    {
+        if (*str == '\\')
+        {
+            str++;
+            if (*str == 'n')
+                putchar('\n');
+            else if (*str == 't')
+                putchar('\t');
+            else if (*str == '\\')
+                putchar('\\');
+            else if (*str == 'a')
+                putchar('\a');
+            else if (*str == 'b')
+                putchar('\b');
+            else if (*str == 'f')
+                putchar('\f');
+            else if (*str == 'r')
+                putchar('\r');
+            else if (*str == 'v')
+                putchar('\v');
+            else if (*str == 'c')
+                return; // stop printing
+            else
+            {
+                // unrecognized escape, print "\"" and the char
+                putchar('\\');
+                if (*str)
+                    putchar(*str);
+            }
+        }
+        else
+        {
+            putchar(*str);
+        }
+        str++;
+    }
+}
+
 static int builtin_echo(char **argv)
 {
     bool newline = true;
+    bool interpret_escapes = false;
     int i = 1;
 
-    if (argv[1] && strcmp(argv[1], "-n") == 0)
+    // Parse options
+    while (argv[i] && argv[i][0] == '-')
     {
-        newline = false;
+        char *opt = argv[i] + 1; // skip "-"
+        bool valid_option = false;
+        while (*opt)
+        {
+            if (*opt == 'n')
+            {
+                newline = false;
+                valid_option = true;
+            }
+            else if (*opt == 'e')
+            {
+                interpret_escapes = true;
+                valid_option = true;
+            }
+            else if (*opt == 'E')
+            {
+                interpret_escapes = false;
+                valid_option = true;
+            }
+            else
+            {
+                // invalid option so euh treat as regular argument
+                valid_option = false;
+                break;
+            }
+            opt++;
+        }
+        if (!valid_option)
+            break; // stop parsing options
         i++;
     }
 
+    // Print arguments
     for (; argv[i]; i++)
     {
-        printf("%s", argv[i]);
+        if (interpret_escapes)
+            print_with_escapes(argv[i]);
+        else
+            printf("%s", argv[i]);
         if (argv[i + 1])
             printf(" ");
     }
@@ -234,6 +483,17 @@ static int builtin_echo(char **argv)
     return 0;
 }
 
+static int builtin_break(char **argv)
+{
+    (void)argv;
+    return EXEC_SIGNAL_BREAK;
+}
+
+static int builtin_continue(char **argv)
+{
+    (void)argv;
+    return EXEC_SIGNAL_CONTINUE;
+}
 
 static int builtin_true(char **argv)
 {
@@ -247,17 +507,24 @@ static int builtin_false(char **argv)
     return 1;
 }
 
-static int builtin_exit(char **argv)
+static int builtin_exit(char **argv, struct hash_map *vars)
 {
     int exit_val = 0;
     if (argv[1])
-        exit_val = atoi(argv[1]);
-    exit(exit_val);
-    return exit_val;
+    {
+        exit_val = atou(argv[1]);
+        if (exit_val == -1)
+        {
+            fprintf(stderr, "exit: Illegal number %s\n", argv[1]);
+            return 2;
+        }
+    }
+
+    set_var_int(vars, "EXIT_VALUE", exit_val);
+    return EXEC_SIGNAL_EXIT;
 }
 
-
-static int builtin_cd(char **argv)
+static int builtin_cd(char **argv, struct hash_map *vars)
 {
     const char *path = argv[1];
     if (!path)
@@ -269,14 +536,34 @@ static int builtin_cd(char **argv)
             return 1;
         }
     }
+    // char *pwd = getcwd("", "");
+    char *pwd = get_var_or_env(vars, "PWD");
     if (chdir(path) != 0)
     {
         perror("cd");
         return 1;
     }
+    set_var_copy(vars, "OLD_PWD", pwd);
+    set_var_copy(vars, "PWD", path);
     return 0;
 }
 
+static int builtin_unset(char **argv, struct hash_map *vars)
+{
+    if (!argv)
+        return 0;
+    for (int i = 1; argv[i]; i++)
+    {
+        const char *name = argv[i];
+        if (name == NULL || name[0] == '\0')
+            continue;
+        // remove from shell variables
+        hash_map_remove(vars, name);
+        // remove from environment variables
+        unsetenv(name);
+    }
+    return 0;
+}
 
 /**
  * @brief Tries to execute a builtin command if the command matches a builtin
@@ -284,21 +571,27 @@ static int builtin_cd(char **argv)
  * @param argv Array of command arguments
  * @return int Exit status of the builtin command, or -1 if not a builtin
  */
-static int try_builtin(char **argv)
+static int try_builtin(char **argv, struct hash_map *vars)
 {
     if (!argv || !argv[0])
         return 0;
 
     if (strcmp(argv[0], "echo") == 0)
         return builtin_echo(argv);
+    if (strcmp(argv[0], "unset") == 0)
+        return builtin_unset(argv, vars);
     if (strcmp(argv[0], "true") == 0)
         return builtin_true(argv);
     if (strcmp(argv[0], "false") == 0)
         return builtin_false(argv);
+    if (strcmp(argv[0], "break") == 0)
+        return builtin_break(argv);
+    if (strcmp(argv[0], "continue") == 0)
+        return builtin_continue(argv);
     if (strcmp(argv[0], "exit") == 0)
-        return builtin_exit(argv);
+        return builtin_exit(argv, vars);
     if (strcmp(argv[0], "cd") == 0)
-        return builtin_cd(argv);
+        return builtin_cd(argv, vars);
 
     return -1;
 }

src/execution/execution_helpers.h

@@ -4,10 +4,18 @@
 #include "../utils/ast/ast.h"
 #include "../utils/hash_map/hash_map.h"
 
+// Special execution signals used internally to implement loop control
+#define EXEC_SIGNAL_CONTINUE (-2)
+#define EXEC_SIGNAL_BREAK (-3)
+#define EXEC_SIGNAL_EXIT (-4)
+
 int exec_ast_command(struct ast_command *command, struct hash_map *vars);
 int exec_ast_if(struct ast_if *if_node, struct hash_map *vars);
 int exec_ast_list(struct ast_list *list_node, struct hash_map *vars);
 int exec_ast_and_or(struct ast_and_or *ao_node, struct hash_map *vars);
-int exec_ast_redir(struct ast_redir *redir, struct hash_map *vars);
+int exec_ast_loop(struct ast_loop *loop_node, struct hash_map *vars);
+int exec_ast_subshell(struct ast_subshell *subshell_node,
+                        struct hash_map *vars);
 
+void unset_all_redir(struct list *redir_list);
 #endif // EXECUTION_HELPERS_H

src/expansion/expansion.c

@@ -1,4 +1,6 @@
 #define _POSIX_C_SOURCE 200809L
+#include "expansion.h"
+
 #include <ctype.h>
 #include <stdbool.h>
 #include <stdio.h>
@@ -115,6 +117,40 @@ static bool expand_var(char **str, size_t pos, const struct hash_map *vars)
     return false;
 }
 
+size_t parse_subshell_str(char *str, char **res)
+{
+    size_t i = 1; // skip the '('
+    int paren_count = 1;
+
+    if (str[i] == ')')
+    {
+        // empty subshell
+        *res = NULL;
+        return 0;
+    }
+
+    while (str[i] != 0)
+    {
+        if (str[i] == '(')
+            paren_count++;
+        else if (str[i] == ')')
+        {
+            paren_count--;
+
+            if (paren_count == 0)
+            {
+                *res = strndup(str + 1, i - 1);
+                return i + 1;
+            }
+        }
+        i++;
+    }
+
+    // error: parenthesis not closed
+    *res = NULL;
+    return 0;
+}
+
 bool expand(struct ast_command *command, const struct hash_map *vars)
 {
     if (command == NULL)
@@ -122,25 +158,39 @@ bool expand(struct ast_command *command, const struct hash_map *vars)
 
     char *str;
     size_t len;
-    bool in_quotes;
+    enum quote_state quotes;
     struct list *l = command->command;
 
     while (l != NULL)
     {
-        in_quotes = false;
+        quotes = NO_QUOTE;
         str = (char *)l->data;
         len = strlen(str);
 
         for (size_t i = 0; str[i] != 0; i++)
         {
-            if (str[i] == '\'')
+            if (str[i] == '\'' || str[i] == '\"')
             {
+                if (quotes == NO_QUOTE)
+                {
+                    quotes = (str[i] == '\'') ? SINGLE_QUOTE : DOUBLE_QUOTE;
+                }
+                else if ((quotes == SINGLE_QUOTE && str[i] == '\'')
+                         || (quotes == DOUBLE_QUOTE && str[i] == '\"'))
+                {
+                    quotes = NO_QUOTE;
+                }
+                else
+                {
+                    // inside the other quote type, do nothing
+                    continue;
+                }
+
                 // remove quote
-                in_quotes = !in_quotes;
                 memmove(str + i, str + i + 1, strlen(str + i + 1) + 1);
                 i--;
             }
-            else if (in_quotes)
+            else if (quotes == SINGLE_QUOTE)
             {
                 continue; // do nothing
             }
@@ -155,21 +205,20 @@ bool expand(struct ast_command *command, const struct hash_map *vars)
             }
         }
 
-        if (in_quotes)
-        {
-            // error: quote not closed
-            fprintf(stderr, "Error: quote not closed in string: %s\n", str);
-            return false;
-        }
+        // if (quotes != NO_QUOTE)
+        // {
+        //     // error: quote not closed
+        //     fprintf(stderr, "Error: quote not closed in string: %s\n", str);
+        //     return false;
+        // }
 
         if (len != strlen(str))
         {
             char *new_str = realloc(str, strlen(str) + 1);
             if (new_str == NULL)
-            {
                 // error: realloc fail
                 return false;
-            }
+
             l->data = new_str;
         }
 

src/expansion/expansion.h

@@ -7,6 +7,13 @@
 #include "../utils/ast/ast.h"
 #include "../utils/hash_map/hash_map.h"
 
+enum quote_state
+{
+    NO_QUOTE,
+    SINGLE_QUOTE,
+    DOUBLE_QUOTE
+};
+
 /**
  * Parse a variable from a string starting with '$'.
  * @param str The input string starting with '$'. It must start with '$'.
@@ -16,6 +23,15 @@
  */
 size_t parse_var_name(char *str, char **res);
 
+/**
+ * Parse a subshell string enclosed in parentheses.
+ * @param str The input string starting with '('. It must start with '('.
+ * @param res Pointer to a char pointer that will be set to the extracted
+ * subshell string.
+ * @return The number of characters processed in the input string.
+ */
+size_t parse_subshell_str(char *str, char **res);
+
 /**
  * Expand variables in an AST command using the provided variable map.
  * @param command The AST command to expand.

src/lexer/lexer.c

@@ -78,21 +78,43 @@ static bool update_lexing_mode(char *stream, ssize_t i,
     return *lexing_mode != mode_before_update;
 }
 
+/* @brief: updates the flags only_digits and has_equal.
+ *         according to the character at stream[i].
+ */
+static void update_flags(char *stream, ssize_t i, struct token_info *info)
+{
+    if (stream[i] == '=' && !info->has_equal)
+    {
+        if (i == 0)
+        {
+            perror("Syntax error: word start with a '='");
+            return;
+        }
+        else
+            info->has_equal = true;
+    }
+    else if (!isdigit(stream[i]) && info->only_digits)
+    {
+        info->only_digits = false;
+    }
+}
+
 struct token *peek_token(struct lexer_context *ctx)
 {
+    stream_init(ctx);
+
+    // Usefull to know if we are inside a quote or double quote
+    enum lexing_mode lexing_mode = LEXER_NORMAL;
+    struct token_info info = { true, 0 };
+    char *stream = ctx->end_previous_token;
+    ssize_t i = 0;
+
     // we already created the upcoming token during the previous call to peek()
     if (ctx->current_token != NULL)
     {
         return ctx->current_token;
     }
 
-    stream_init(ctx);
-    char *stream = ctx->end_previous_token;
-    ssize_t i = 0;
-
-    // Usefull to know if we are inside a quote or double quote
-    enum lexing_mode lexing_mode = LEXER_NORMAL;
-
     while (i < ctx->remaining_chars)
     {
         // true if we didn't encounter a quote of any type at stream[i]
@@ -100,6 +122,7 @@ struct token *peek_token(struct lexer_context *ctx)
         if (!update_lexing_mode(stream, i, &lexing_mode)
             && lexing_mode == LEXER_NORMAL)
         {
+            update_flags(stream, i, &info);
             if (is_special_char(stream, i))
             {
                 if (i == 0) // where we create spe_char token
@@ -121,7 +144,7 @@ struct token *peek_token(struct lexer_context *ctx)
         i++;
     }
 
-    struct token *tok = new_token(stream, i, ctx->only_digits);
+    struct token *tok = new_token(stream, i, &info);
     // if token is comment, we don't want it
 
     if (tok->type == TOKEN_COMMENT)
@@ -138,6 +161,14 @@ struct token *peek_token(struct lexer_context *ctx)
 
 struct token *pop_token(struct lexer_context *ctx)
 {
+    stream_init(ctx);
+
+    // Usefull to know if we are inside a quote or double quote
+    enum lexing_mode lexing_mode = LEXER_NORMAL;
+    struct token_info info = { true, 0 };
+    char *stream = ctx->end_previous_token;
+    ssize_t i = 0;
+
     if (ctx->current_token != NULL && ctx->current_token->type == TOKEN_EOF)
     {
         // we reached end of input, frees all the token still allocated.
@@ -145,12 +176,6 @@ struct token *pop_token(struct lexer_context *ctx)
         free_token(&ctx->current_token);
         return NULL;
     }
-    stream_init(ctx);
-    char *stream = ctx->end_previous_token;
-    ssize_t i = 0;
-
-    // Usefull to know if we are inside a quote or double quote
-    enum lexing_mode lexing_mode = LEXER_NORMAL;
 
     while (i < ctx->remaining_chars)
     {
@@ -159,6 +184,7 @@ struct token *pop_token(struct lexer_context *ctx)
         if (!update_lexing_mode(stream, i, &lexing_mode)
             && lexing_mode == LEXER_NORMAL)
         {
+            update_flags(stream, i, &info);
             if (is_special_char(stream, i))
             {
                 if (i == 0) // where we create spe_char token
@@ -184,7 +210,7 @@ struct token *pop_token(struct lexer_context *ctx)
     // (this should never happen)
     if (ctx->current_token == NULL)
     {
-        ctx->current_token = new_token(stream, i, ctx->only_digits);
+        ctx->current_token = new_token(stream, i, &info);
     }
     save_state(stream, i, ctx);
 

src/lexer/lexer_utils.c

@@ -72,10 +72,18 @@ static void set_token_keyword(struct token *tok, char *begin, ssize_t size)
         tok->type = TOKEN_ELSE;
     else if (strncmp(begin, "elif", size) == 0 && size == 4)
         tok->type = TOKEN_ELIF;
-    else if (strncmp(begin, "&&", size) == 0 && size == 2)
-        tok->type = TOKEN_AND;
-    else if (strncmp(begin, "||", size) == 0 && size == 2)
-        tok->type = TOKEN_OR;
+    else if (strncmp(begin, "for", size) == 0 && size == 3)
+        tok->type = TOKEN_FOR;
+    else if (strncmp(begin, "while", size) == 0 && size == 5)
+        tok->type = TOKEN_WHILE;
+    else if (strncmp(begin, "until", size) == 0 && size == 5)
+        tok->type = TOKEN_UNTIL;
+    else if (strncmp(begin, "do", size) == 0 && size == 2)
+        tok->type = TOKEN_DO;
+    else if (strncmp(begin, "done", size) == 0 && size == 4)
+        tok->type = TOKEN_DONE;
+    else if (strncmp(begin, "export", size) == 0 && size == 6)
+        tok->type = TOKEN_EXPORT;
 
     // no keywords found.
     if (tok->type == TOKEN_NULL)
@@ -97,35 +105,44 @@ static void set_token_operator(struct token *tok, char *begin, ssize_t size)
 {
     if (tok->type != TOKEN_NULL)
         return;
-    if (strncmp(begin, ">", size) == 0)
+    if (strncmp(begin, "&&", size) == 0 && size == 2)
+    {
+        tok->type = TOKEN_AND;
+    }
+    else if (strncmp(begin, "||", size) == 0 && size == 2)
+    {
+        tok->type = TOKEN_OR;
+    }
+
+    else if (strncmp(begin, ">", size) == 0 && size == 1)
     {
         tok->type = TOKEN_REDIR_RIGHT;
     }
-    else if (strncmp(begin, "<", size) == 0)
+    else if (strncmp(begin, "<", size) == 0 && size == 1)
     {
         tok->type = TOKEN_REDIR_LEFT;
     }
-    else if (strncmp(begin, ">>", size) == 0)
+    else if (strncmp(begin, ">>", size) == 0 && size == 2)
     {
         tok->type = TOKEN_REDIR_DOUBLE_RIGHT;
     }
-    else if (strncmp(begin, ">&", size) == 0)
+    else if (strncmp(begin, ">&", size) == 0 && size == 2)
     {
         tok->type = TOKEN_REDIR_RIGHT_AMP;
     }
-    else if (strncmp(begin, ">|", size) == 0)
+    else if (strncmp(begin, ">|", size) == 0 && size == 2)
     {
         tok->type = TOKEN_REDIR_RIGHT_PIPE;
     }
-    else if (strncmp(begin, "<&", size) == 0)
+    else if (strncmp(begin, "<&", size) == 0 && size == 2)
     {
         tok->type = TOKEN_REDIR_LEFT_AMP;
     }
-    else if (strncmp(begin, "<>", size) == 0)
+    else if (strncmp(begin, "<>", size) == 0 && size == 2)
     {
         tok->type = TOKEN_REDIR_LEFT_RIGHT;
     }
-    else if (strncmp(begin, "|", size) == 0)
+    else if (strncmp(begin, "|", size) == 0 && size == 1)
     {
         tok->type = TOKEN_PIPE;
     }
@@ -146,6 +163,21 @@ static void set_token_word(struct token *tok, char *begin, ssize_t size)
     }
 }
 
+/* @brief: Sets the token to an assignment_word
+ *         Also allocates the data and fills it.
+ */
+static void set_token_assignment(struct token *tok, char *begin, ssize_t size)
+{
+    if (tok->type == TOKEN_NULL && size != 0)
+    {
+        tok->type = TOKEN_ASSIGNMENT_WORD;
+        tok->data = calloc(size + 1, sizeof(char));
+        if (tok->data == NULL)
+            return;
+        strncpy(tok->data, begin, size);
+    }
+}
+
 /* @brief: Sets the token to an IO number
  *         Also allocates the data and fills it.
  */
@@ -204,33 +236,38 @@ bool is_special_char(char *stream, ssize_t i)
     return strchr(special_chars, c) != NULL;
 }
 
-struct token *new_token(char *begin, ssize_t size, bool only_digits)
+struct token *new_token(char *begin, ssize_t size, struct token_info *info)
 {
     struct token *tok = calloc(1, sizeof(struct token));
     if (tok == NULL)
         return NULL;
 
-    if (only_digits)
+    if (info->only_digits)
         set_token_ION(tok, begin, size);
-
-    set_token_operator(tok, begin, size);
-    set_token_spechar(tok, begin, size);
-    set_token_keyword(tok, begin, size);
-    set_token_word(tok, begin, size);
+    else if (info->has_equal)
+        set_token_assignment(tok, begin, size);
+    else
+    {
+        set_token_keyword(tok, begin, size);
+        set_token_operator(tok, begin, size);
+        set_token_spechar(tok, begin, size);
+        set_token_word(tok, begin, size);
+    }
 
     return tok;
 }
 
-void destroy_lexer_context(struct lexer_context **ctx)
+void destroy_lexer_context(struct lexer_context *ctx)
 {
-    if (ctx == NULL || *ctx == NULL)
+    struct token *prev = ctx->previous_token;
+    struct token *cur = ctx->current_token;
+    if (ctx == NULL)
         return;
-    if ((*ctx)->previous_token != NULL)
-        free((*ctx)->previous_token);
-    if ((*ctx)->current_token != NULL)
-        free((*ctx)->current_token);
-    free(*ctx);
-    *ctx = NULL;
+    if (prev != NULL)
+        free_token(&prev);
+    if (cur != NULL)
+        free_token(&cur);
+    free(ctx);
 }
 
 void free_token(struct token **tok)
@@ -267,10 +304,19 @@ ssize_t len_op_sepchar(char *stream, ssize_t i)
     if (!is_special_char(stream, i))
         return -1; // should never happen
 
-    if (stream[i] != '>' && stream[i] != '<')
-        return 1; // special character (cannot be operator)
+    // OR
+    if (stream[i] == '|' && stream[i + 1] == '|')
+        return 2;
 
-    // operator
+    // AND
+    if (stream[i] == '&' && stream[i + 1] == '&')
+        return 2;
+
+    // special chars
+    if (stream[i] != '>' && stream[i] != '<')
+        return 1;
+
+    // REDIRS
 
     if (stream[i] == '<')
     {

src/lexer/lexer_utils.h

@@ -10,17 +10,13 @@ struct lexer_context
     char *end_previous_token;
     ssize_t remaining_chars;
 
-    // usefull to detect IO numbers.
-    // tells us if we only lexed digits in current token.
-    bool only_digits;
-
     struct token *previous_token;
     struct token *current_token;
 };
 
 /* @brief: frees all fields of ctx and sets ctx to NULL.
  */
-void destroy_lexer_context(struct lexer_context **ctx);
+void destroy_lexer_context(struct lexer_context *ctx);
 
 enum lexing_mode
 {
@@ -34,10 +30,13 @@ enum token_type
     // Blanks
     TOKEN_NULL = 0,
     TOKEN_EOF,
-    TOKEN_WORD,
     TOKEN_NEWLINE,
 
-    // SPecial characters
+    // words
+    TOKEN_WORD,
+    TOKEN_ASSIGNMENT_WORD,
+
+    // Special characters
     TOKEN_GRAVE,
     TOKEN_SEMICOLON,
     TOKEN_COMMENT,
@@ -51,10 +50,6 @@ enum token_type
     TOKEN_PIPE,
     TOKEN_NEGATION,
 
-    // TODO merge into one and use the data field
-    // (Too difficult to handle in the parser because of firsts)
-    // TOKEN_REDIRECTION
-    //
     // Redirections
     TOKEN_REDIR_LEFT,
     TOKEN_REDIR_RIGHT,
@@ -73,7 +68,14 @@ enum token_type
     TOKEN_FI,
     TOKEN_ELIF,
     TOKEN_AND,
-    TOKEN_OR
+    TOKEN_OR,
+    TOKEN_FOR,
+    TOKEN_WHILE,
+    TOKEN_UNTIL,
+    TOKEN_CASE,
+    TOKEN_EXPORT,
+    TOKEN_DO,
+    TOKEN_DONE
 };
 
 struct token
@@ -82,17 +84,29 @@ struct token
     char *data;
 };
 
+// used to give info from lexing when creating a new token.
+struct token_info
+{
+    // usefull to detect IO numbers.
+    // tells us if we only lexed digits in current token.
+    bool only_digits;
+
+    // usefull to detect assignments, and syntax errors with '='.
+    bool has_equal;
+};
+
 /* @return: true if a special character from the grammar was found at stream[i],
  *          false otherwise.
  */
 bool is_special_char(char *stream, ssize_t i);
 
-/* @brief: return a newly allocated token, with the corresponding type.
+/* @brief: return a newly allocated token, with the type corresponding
+ *         to the info given in arguments.
  *         The data contains [size] char, starting from [begin].
  *
  * @return: NULL on error, a token otherwise.
  */
-struct token *new_token(char *begin, ssize_t size, bool only_digits);
+struct token *new_token(char *begin, ssize_t size, struct token_info *info);
 
 /* @brief: frees the token given in argument
  */

src/main.c

@@ -7,71 +7,9 @@
 #include "lexer/lexer.h"
 #include "parser/parser.h"
 #include "utils/args/args.h"
+#include "utils/main_loop/main_loop.h"
 #include "utils/vars/vars.h"
 
-// === Error codes
-
-#define SUCCESS 0
-#define ERR_INPUT_PROCESSING 2
-#define ERR_MALLOC 3
-#define ERR_GENERIC 4
-
-// === Functions
-
-/* @brief: frees the hash map.
- * @return: always ERR_INPUT_PROCESSING.
- */
-static int err_input(struct hash_map **vars)
-{
-    hash_map_free(vars);
-    return ERR_INPUT_PROCESSING;
-}
-
-static int main_loop(struct lexer_context *ctx, struct args_options *options,
-                     struct hash_map *vars)
-{
-    int return_code = SUCCESS;
-    // init parser
-    if (!parser_init())
-    {
-        perror("parser initialization failed.");
-    }
-
-    // Retrieve and build first AST
-    struct ast *command_ast = get_ast(ctx);
-
-    if (options->pretty_print)
-    {
-        ast_print_dot(command_ast);
-    }
-
-    // Main parse-execute loop
-    while (command_ast != NULL && command_ast->type != AST_END)
-    {
-        if (command_ast->type != AST_VOID)
-        {
-            // Execute AST
-            return_code = execution(command_ast, vars);
-
-            // set $? variable
-            set_var_int(vars, "?", return_code);
-        }
-
-        ast_free(&command_ast);
-
-        // Retrieve and build next AST
-        command_ast = get_ast(ctx);
-    }
-
-    if (command_ast == NULL)
-        return err_input(&vars);
-
-    ast_free(&command_ast);
-    parser_close();
-
-    return return_code;
-}
-
 int main(int argc, char **argv)
 {
     struct hash_map *vars = vars_init();
@@ -87,7 +25,7 @@ int main(int argc, char **argv)
     if (return_code != 0)
     {
         print_usage(stderr, argv[0]);
-        return err_input(&vars);
+        return err_input(&vars, NULL);
     }
     // args_print(&options);
 
@@ -102,7 +40,7 @@ int main(int argc, char **argv)
     {
         fprintf(stderr,
                 "Error: Failed to configure IO Backend from arguments\n");
-        return err_input(&vars);
+        return err_input(&vars, NULL);
     }
 
     // Init IO Backend (with the context struct)
@@ -112,17 +50,22 @@ int main(int argc, char **argv)
         fprintf(stderr,
                 "Error: IO Backend initialization failed with code %d\n",
                 return_code);
-        return err_input(&vars);
+        return err_input(&vars, NULL);
     }
 
     // init lexer context
-    struct lexer_context ctx = { 0 };
+    struct lexer_context *ctx = calloc(1, sizeof(struct lexer_context));
 
-    return_code = main_loop(&ctx, &options, vars);
+    // init parser
+    if (!parser_init())
+    {
+        perror("parser initialization failed.");
+        return err_input(&vars, ctx);
+    }
 
-    // === free
+    return_code = main_loop(ctx, vars);
 
-    hash_map_free(&vars);
+    parser_close();
 
     return return_code;
 }

src/parser/grammar.c

@@ -4,7 +4,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-#include "../lexer/lexer.h"
 #include "grammar_basic.h"
 
 // === Static variables
@@ -57,6 +56,23 @@ static bool add_first(enum rule rule, enum token_type token)
     return true;
 }
 
+/* @brief Add a list of tokens to a rule's firsts (in firsts_map)
+ *
+ * @arg rule the rule to which add a first
+ * @arg tokens_list the list of tokens to add to the rule's firsts
+ * @return true on success, false on error
+ */
+static bool add_firsts(enum rule rule, struct firsts_list *tokens_list)
+{
+    for (size_t i = 0; i < tokens_list->list_length; i++)
+    {
+        bool res = add_first(rule, tokens_list->tokens[i]);
+        if (!res)
+            return false;
+    }
+    return true;
+}
+
 /* @brief initializes the firsts_map static variable (does not populate it)
  * @return true on success, false on error
  */
@@ -73,24 +89,125 @@ static bool init_firsts_map(void)
     return true;
 }
 
-/* @brief: add all the redirection token_types to the first of [rule].
- *          this also contains IONUMBER
- */
-static void add_first_redir(enum rule rule)
+static void add_first_redir(void)
 {
-    add_first(rule, TOKEN_IONUMBER);
-    add_first(rule, TOKEN_REDIR_LEFT);
-    add_first(rule, TOKEN_REDIR_RIGHT);
-    add_first(rule, TOKEN_REDIR_LEFT_RIGHT);
-    add_first(rule, TOKEN_REDIR_DOUBLE_RIGHT);
-    add_first(rule, TOKEN_REDIR_LEFT_AMP);
-    add_first(rule, TOKEN_REDIR_RIGHT_AMP);
-    add_first(rule, TOKEN_REDIR_RIGHT_PIPE);
+    add_first(RULE_REDIRECTION, TOKEN_IONUMBER);
+    add_first(RULE_REDIRECTION, TOKEN_REDIR_LEFT);
+    add_first(RULE_REDIRECTION, TOKEN_REDIR_RIGHT);
+    add_first(RULE_REDIRECTION, TOKEN_REDIR_LEFT_RIGHT);
+    add_first(RULE_REDIRECTION, TOKEN_REDIR_DOUBLE_RIGHT);
+    add_first(RULE_REDIRECTION, TOKEN_REDIR_LEFT_AMP);
+    add_first(RULE_REDIRECTION, TOKEN_REDIR_RIGHT_AMP);
+    add_first(RULE_REDIRECTION, TOKEN_REDIR_RIGHT_PIPE);
+}
+
+// Adds only direct tokens to rules firsts into the firsts map
+static void add_firsts_tokens(void)
+{
+    // Redirection
+    add_first_redir();
+    // %RIP Matteo 30/01/2026
+    // %RAX Guillem 30/01/2026 hehe
+
+    // If
+    add_first(RULE_IF, TOKEN_IF);
+
+    // Else clause
+    add_first(RULE_ELSE_CLAUSE, TOKEN_ELSE);
+    add_first(RULE_ELSE_CLAUSE, TOKEN_ELIF);
+
+    // For
+    add_first(RULE_FOR, TOKEN_FOR);
+
+    // While
+    add_first(RULE_WHILE, TOKEN_WHILE);
+
+    // Until
+    add_first(RULE_UNTIL, TOKEN_UNTIL);
+
+    // Case
+    add_first(RULE_CASE, TOKEN_CASE);
+
+    // Case item
+    add_first(RULE_CASE_ITEM, TOKEN_LEFT_PAREN);
+    add_first(RULE_CASE_ITEM, TOKEN_WORD);
+
+    // Shell command
+    add_first(RULE_SHELL_COMMAND, TOKEN_LEFT_BRACKET);
+    add_first(RULE_SHELL_COMMAND, TOKEN_LEFT_PAREN);
+
+    // Simple command
+    add_first(RULE_SIMPLE_COMMAND, TOKEN_WORD);
+    add_first(RULE_SIMPLE_COMMAND, TOKEN_EXPORT);
+
+    // Element
+    add_first(RULE_ELEMENT, TOKEN_WORD);
+    add_first(RULE_ELEMENT, TOKEN_ASSIGNMENT_WORD);
+
+    // Prefix
+    add_first(RULE_PREFIX, TOKEN_ASSIGNMENT_WORD);
+
+    // Pipeline
+    add_first(RULE_PIPELINE, TOKEN_WORD);
+
+    // Compound list
+    add_first(RULE_COMPOUND_LIST, TOKEN_NEWLINE);
+
+    // Input
+    add_first(RULE_INPUT, TOKEN_NEWLINE);
+    add_first(RULE_INPUT, TOKEN_EOF);
+
+    // Funcdec
+    add_first(RULE_FUNCDEC, TOKEN_WORD);
+}
+
+// Adds only firsts that depend on other rules to the firsts map
+// WARNING order matters
+static void add_firsts_rec(void)
+{
+    // Case clause
+    add_firsts(RULE_CASE_CLAUSE, first(RULE_CASE_ITEM));
+
+    // Element
+    add_firsts(RULE_ELEMENT, first(RULE_REDIRECTION));
+
+    // Prefix
+    add_firsts(RULE_PREFIX, first(RULE_REDIRECTION));
+
+    // Shell command
+    add_firsts(RULE_SHELL_COMMAND, first(RULE_IF));
+    add_firsts(RULE_SHELL_COMMAND, first(RULE_FOR));
+    add_firsts(RULE_SHELL_COMMAND, first(RULE_WHILE));
+    add_firsts(RULE_SHELL_COMMAND, first(RULE_UNTIL));
+    add_firsts(RULE_SHELL_COMMAND, first(RULE_CASE));
+
+    // Simple command
+    add_firsts(RULE_SIMPLE_COMMAND, first(RULE_PREFIX));
+
+    // Command
+    add_firsts(RULE_COMMAND, first(RULE_SIMPLE_COMMAND));
+    add_firsts(RULE_COMMAND, first(RULE_SHELL_COMMAND));
+    add_firsts(RULE_COMMAND, first(RULE_FUNCDEC));
+
+    // Pipeline
+    add_firsts(RULE_PIPELINE, first(RULE_COMMAND));
+
+    // And Or
+    add_firsts(RULE_AND_OR, first(RULE_PIPELINE));
+
+    // Compound list
+    add_firsts(RULE_COMPOUND_LIST, first(RULE_AND_OR));
+
+    // List
+    add_firsts(RULE_LIST, first(RULE_AND_OR));
+
+    // Input
+    add_firsts(RULE_INPUT, first(RULE_LIST));
 }
 
 // === Functions
 
-bool grammar_init(void)
+int grammar_init(void)
 {
     // Initialize the firsts map
     bool success = init_firsts_map();
@@ -98,46 +215,8 @@ bool grammar_init(void)
         return false;
 
     // Populate the firsts map
-    add_first(RULE_INPUT, TOKEN_WORD);
-    add_first(RULE_INPUT, TOKEN_IF);
-    add_first(RULE_COMMAND, TOKEN_NEGATION);
-    add_first(RULE_INPUT, TOKEN_NEWLINE);
-    add_first(RULE_INPUT, TOKEN_EOF);
-
-    add_first(RULE_LIST, TOKEN_WORD);
-    add_first(RULE_LIST, TOKEN_IF);
-    add_first(RULE_COMMAND, TOKEN_NEGATION);
-
-    add_first(RULE_AND_OR, TOKEN_WORD);
-    add_first(RULE_AND_OR, TOKEN_IF);
-    add_first(RULE_COMMAND, TOKEN_NEGATION);
-
-    add_first(RULE_PIPELINE, TOKEN_WORD);
-    add_first(RULE_PIPELINE, TOKEN_IF);
-    add_first(RULE_COMMAND, TOKEN_NEGATION);
-
-    add_first(RULE_COMMAND, TOKEN_WORD);
-    add_first(RULE_COMMAND, TOKEN_IF);
-
-    add_first(RULE_SIMPLE_COMMAND, TOKEN_WORD);
-
-    add_first(RULE_SHELL_COMMAND, TOKEN_IF);
-
-    add_first(RULE_IF, TOKEN_IF);
-
-    add_first(RULE_COMPOUND_LIST, TOKEN_NEWLINE);
-    add_first(RULE_COMPOUND_LIST, TOKEN_WORD);
-    add_first(RULE_COMPOUND_LIST, TOKEN_IF);
-
-    add_first(RULE_ELSE_CLAUSE, TOKEN_ELSE);
-    add_first(RULE_ELSE_CLAUSE, TOKEN_ELIF);
-
-    add_first(RULE_ELEMENT, TOKEN_WORD);
-    add_first_redir(RULE_ELEMENT);
-
-    add_first_redir(RULE_REDIRECTION);
-
-    add_first_redir(RULE_PREFIX);
+    add_firsts_tokens();
+    add_firsts_rec();
 
     return true;
 }
@@ -197,16 +276,20 @@ struct ast *parse_input(struct lexer_context *ctx)
     }
 
     struct ast *ast = parse_list(ctx);
-    if (ast == NULL)
-        return NULL;
-
     token = PEEK_TOKEN();
-    if (token->type == TOKEN_NEWLINE || token->type == TOKEN_EOF)
+
+    if (ast == NULL)
     {
-        if (token->type == TOKEN_NEWLINE)
+        if (token != NULL && token->type == TOKEN_EOF)
         {
             POP_TOKEN();
         }
+        return NULL;
+    }
+
+    if (token->type == TOKEN_NEWLINE || token->type == TOKEN_EOF)
+    {
+        POP_TOKEN();
         return ast;
     }
 

src/parser/grammar.h

@@ -41,6 +41,13 @@ enum rule
     RULE_ELEMENT,
     RULE_REDIRECTION,
     RULE_PREFIX,
+    RULE_FUNCDEC,
+    RULE_WHILE,
+    RULE_UNTIL,
+    RULE_FOR,
+    RULE_CASE,
+    RULE_CASE_CLAUSE,
+    RULE_CASE_ITEM,
     NUMBER_OF_RULES
 };
 
@@ -57,7 +64,7 @@ struct firsts_list
  * @return PARSER_INIT_SUCCESS on success PARSER_INIT_ERROR on error
  * @warning Do not use outside the parser
  */
-bool grammar_init(void);
+int grammar_init(void);
 
 /*
  * @brief Closes the grammar submodule
@@ -89,6 +96,7 @@ bool is_first(struct token token, enum rule rule);
  *             | '\n'
  *             | EOF
  *             ;
+ * @first first(list), '\n', EOF
  */
 struct ast *parse_input(struct lexer_context *ctx);
 

src/parser/grammar_advanced.c

@@ -6,8 +6,11 @@
 #include <stdlib.h>
 #include <string.h>
 
+#include "grammar.h"
 #include "grammar_basic.h"
 
+// === Static functions
+
 static enum ast_redir_type redir_tok_to_ast_type(enum token_type tok_type)
 {
     switch (tok_type)
@@ -16,12 +19,86 @@ static enum ast_redir_type redir_tok_to_ast_type(enum token_type tok_type)
         return AST_REDIR_TYPE_LESS;
     case TOKEN_REDIR_RIGHT:
         return AST_REDIR_TYPE_GREAT;
-        // TODO finish this
+    case TOKEN_REDIR_DOUBLE_RIGHT:
+        return AST_REDIR_TYPE_DGREAT;
+    case TOKEN_REDIR_LEFT_RIGHT:
+        return AST_REDIR_TYPE_LESSGREAT;
+    case TOKEN_REDIR_LEFT_AMP:
+        return AST_REDIR_TYPE_LESSAND;
+    case TOKEN_REDIR_RIGHT_AMP:
+        return AST_REDIR_TYPE_GREATAND;
+    case TOKEN_REDIR_RIGHT_PIPE:
+        return AST_REDIR_TYPE_CLOBBER;
     default:
         return AST_REDIR_TYPE_NULL;
     }
 }
 
+/*
+ * @brief parses a while/until loop starting with the condition
+ * (after the while/until keyword)
+ * @arg negate_condition Set to true for until loops, false for while loops
+ */
+static struct ast *parse_loop(struct lexer_context *ctx, bool negate_condition)
+{
+    // condition
+    struct ast *condition = parse_compound_list(ctx);
+    if (condition == NULL)
+        return NULL;
+    if (negate_condition)
+    {
+        condition =
+            ast_create_neg(true, condition); // TODO check result (beware to not
+                                             // exceed the function lines limit)
+    }
+
+    struct token *token = PEEK_TOKEN();
+
+    // 'do'
+    if (token->type != TOKEN_DO)
+    {
+        ast_free(&condition);
+        perror("Syntax error: expected the 'do' keyowrd but got a different "
+               "token");
+        return NULL;
+    }
+    POP_TOKEN();
+    token = PEEK_TOKEN();
+
+    // body
+    struct ast *body = parse_compound_list(ctx);
+    if (body == NULL)
+    {
+        ast_free(&condition);
+        return NULL;
+    }
+    token = PEEK_TOKEN();
+
+    // 'done'
+    if (token->type != TOKEN_DONE)
+    {
+        ast_free(&condition);
+        perror("Syntax error: expected the 'done' keyowrd but got a different "
+               "token");
+        return NULL;
+    }
+    POP_TOKEN();
+
+    struct ast *result = ast_create_loop(condition, body);
+    if (result == NULL)
+    {
+        ast_free(&condition);
+        ast_free(&body);
+        perror("Internal error: could not create ast node (is your memory full "
+               "?)");
+        return NULL;
+    }
+
+    return result;
+}
+
+// === Functions
+
 struct ast *parse_redirection(struct lexer_context *ctx)
 {
     struct token *token = PEEK_TOKEN();
@@ -57,5 +134,107 @@ struct ast *parse_redirection(struct lexer_context *ctx)
 
 struct ast *parse_prefix(struct lexer_context *ctx)
 {
-    return parse_redirection(ctx);
+    struct token *token = PEEK_TOKEN();
+    if (token->type == TOKEN_ASSIGNMENT_WORD)
+    {
+        token = POP_TOKEN();
+        return ast_create_assignment(token->data, false);
+    }
+    else if (is_first(*token, RULE_REDIRECTION))
+        return parse_redirection(ctx);
+    else
+    {
+        perror("Syntax error: expected a prefix (redirection or assignment)");
+        return NULL;
+    }
+}
+
+struct ast *parse_funcdec(struct lexer_context *ctx)
+{
+    struct token *token = PEEK_TOKEN();
+    struct ast *value = NULL;
+    char *func_name = NULL;
+
+    if (token->type != TOKEN_WORD)
+    {
+        return NULL;
+    }
+
+    // word -> func name
+    POP_TOKEN();
+    func_name = strdup(token->data);
+
+    // (
+    token = PEEK_TOKEN();
+    if (token->type != TOKEN_LEFT_PAREN)
+    {
+        free(func_name);
+        return NULL;
+    }
+    POP_TOKEN();
+
+    // )
+    token = PEEK_TOKEN();
+    if (token->type != TOKEN_RIGHT_PAREN)
+    {
+        free(func_name);
+        return NULL;
+    }
+    POP_TOKEN();
+    token = PEEK_TOKEN();
+
+    // { \n }
+    while (token->type == TOKEN_NEWLINE)
+    {
+        POP_TOKEN();
+        token = PEEK_TOKEN();
+    }
+
+    // shell_command -> value
+    value = parse_shell_command(ctx);
+    if (value == NULL)
+    {
+        free(func_name);
+        return NULL;
+    }
+    return ast_create_function(func_name, value);
+}
+
+struct ast *parse_for(struct lexer_context *ctx)
+{
+    (void)ctx;
+    perror("Error: usage of a not implemented function (parse_for)");
+    return NULL;
+}
+
+struct ast *parse_while(struct lexer_context *ctx)
+{
+    struct token *token = PEEK_TOKEN();
+
+    // 'while'
+    if (token->type != TOKEN_WHILE)
+    {
+        perror(
+            "Internal error: expected a TOKEN_WHILE but got a different type");
+        return NULL;
+    }
+    POP_TOKEN();
+
+    return parse_loop(ctx, false);
+}
+
+struct ast *parse_until(struct lexer_context *ctx)
+{
+    struct token *token = PEEK_TOKEN();
+
+    // 'until'
+    if (token->type != TOKEN_UNTIL)
+    {
+        perror(
+            "Internal error: expected a TOKEN_UNTIL but got a different type");
+        return NULL;
+    }
+    POP_TOKEN();
+
+    return parse_loop(ctx, true);
 }

src/parser/grammar_advanced.h

@@ -24,4 +24,45 @@ struct ast *parse_redirection(struct lexer_context *ctx);
  */
 struct ast *parse_prefix(struct lexer_context *ctx);
 
+/*
+ * @brief parses a funcdec rule
+ * @warning Work in progress
+ *
+ * @code funcdec = WORD '(' ')' {'\n'} shell_command ;
+ *
+ * @first WORD
+ */
+struct ast *parse_funcdec(struct lexer_context *ctx);
+
+/*
+ * @brief parses a for rule
+ *
+ * @code rule_for = 'for' WORD
+ *                  ( [';'] | [ {'\n'} 'in' { WORD } ( ';' | '\n' ) ] )
+ *                  {'\n'} 'do' compound_list 'done' ;
+ *
+ * @first TOKEN_FOR
+ */
+struct ast *parse_for(struct lexer_context *ctx);
+
+/*
+ * @brief parses a while rule
+ * @warning NOT IMPLEMENTED
+ *
+ * @code rule_while = 'while' compound_list 'do' compound_list 'done' ;
+ *
+ * @first TOKEN_WHILE
+ */
+struct ast *parse_while(struct lexer_context *ctx);
+
+/*
+ * @brief parses an until rule
+ * @warning NOT IMPLEMENTED
+ *
+ * @code rule_until = 'until' compound_list 'do' compound_list 'done' ;
+ *
+ * @first TOKEN_UNTIL
+ */
+struct ast *parse_until(struct lexer_context *ctx);
+
 #endif /* ! GRAMMAR_ADVANCED_H */

src/parser/grammar_basic.c

@@ -26,6 +26,58 @@ static enum ast_and_or_type and_or_tok_to_ast(enum token_type tok_type)
     }
 }
 
+/* @brief: frees all the arguments. (helper func)
+ * @return: NULL.
+ */
+static void *err_if_rule(struct ast **cond, struct ast **then_clause,
+                         struct ast **else_clause)
+{
+    ast_free(cond);
+    ast_free(then_clause);
+    ast_free(else_clause);
+    return NULL;
+}
+
+/* @brief: frees command_elements and redirections lists (helper func)
+ * @return: NULL
+ */
+static void *err_s_com(struct list *command_elements, struct list *redirections,
+                       struct list *assignments)
+{
+    list_deep_destroy(command_elements);
+    list_deep_destroy(redirections);
+    list_deep_destroy(assignments);
+    return NULL;
+}
+
+/* @brief: used when export keyword is found, and expects an assignment after.
+ * @return: an ast_assignment with the field [global] set to true.
+ */
+static struct ast *parse_export(struct lexer_context *ctx)
+{
+    struct token *token = PEEK_TOKEN();
+    if (token->type != TOKEN_EXPORT)
+    {
+        fprintf(stderr, "expected the export keyword in parse_export");
+        return NULL;
+    }
+    // export
+    POP_TOKEN();
+
+    token = PEEK_TOKEN();
+
+    if (token->type != TOKEN_ASSIGNMENT_WORD)
+    {
+        fprintf(stderr, "in parser: export must be followed by 'x=y'");
+        return NULL;
+    }
+
+    // assignment
+    POP_TOKEN();
+
+    return ast_create_assignment(token->data, true);
+}
+
 // === Functions
 
 struct ast *parse_list(struct lexer_context *ctx)
@@ -45,8 +97,13 @@ struct ast *parse_list(struct lexer_context *ctx)
     token = PEEK_TOKEN();
     while (token->type == TOKEN_SEMICOLON)
     {
-        token = POP_TOKEN();
+        // Forward
+        POP_TOKEN();
         token = PEEK_TOKEN();
+
+        // TODO seems a little akward (not fully compliant with the grammar)
+        // but it's time consuming to rewrite to only cover edge cases.
+        // So it'll probably stay like that for now
         if (is_first(*token, RULE_AND_OR))
         {
             current_node = parse_and_or(ctx);
@@ -73,16 +130,11 @@ struct ast *parse_and_or(struct lexer_context *ctx)
 
     while (token->type == TOKEN_AND || token->type == TOKEN_OR)
     {
-        // Set left part
-
+        // Build AST (left part)
+        enum ast_and_or_type type = and_or_tok_to_ast(token->type);
         struct ast *left = result;
 
-        // eat and_or token
-        token = POP_TOKEN();
-
-        // Set type
-        enum ast_and_or_type type = and_or_tok_to_ast(token->type);
-
+        POP_TOKEN();
         token = PEEK_TOKEN();
 
         // Skip newlines
@@ -94,6 +146,12 @@ struct ast *parse_and_or(struct lexer_context *ctx)
 
         // Right part
         struct ast *right = parse_pipeline(ctx);
+        if (right == NULL)
+        {
+            ast_free(&left);
+            return NULL;
+        }
+        token = PEEK_TOKEN();
 
         result = ast_create_and_or(left, right, type);
         if (result == NULL)
@@ -120,30 +178,33 @@ struct ast *parse_pipeline(struct lexer_context *ctx)
         token = PEEK_TOKEN();
     }
 
+    // command rule
     struct ast *left = parse_command(ctx);
+    token = PEEK_TOKEN();
     if (negation)
     {
         left = ast_create_neg(negation, left);
     }
 
-    token = PEEK_TOKEN();
+    // Pipes
     while (token->type == TOKEN_PIPE)
     {
         POP_TOKEN();
+        token = PEEK_TOKEN();
 
         // skip newlines
-        token = PEEK_TOKEN();
         while (token->type == TOKEN_NEWLINE)
         {
             POP_TOKEN();
             token = PEEK_TOKEN();
         }
 
+        // command rule
         struct ast *right = parse_command(ctx);
+        token = PEEK_TOKEN();
 
         // Create AST
         left = ast_create_pipe(left, right);
-        token = PEEK_TOKEN();
     }
 
     return left;
@@ -152,38 +213,83 @@ struct ast *parse_pipeline(struct lexer_context *ctx)
 struct ast *parse_command(struct lexer_context *ctx)
 {
     struct token *token = PEEK_TOKEN();
+    struct ast *result = NULL;
 
-    if (token->type == TOKEN_WORD)
+    if (is_first(*token, RULE_SIMPLE_COMMAND))
     {
-        return parse_simple_command(ctx);
+        result = parse_simple_command(ctx);
     }
-    else if (token->type == TOKEN_IF)
+    else if (is_first(*token, RULE_SHELL_COMMAND))
     {
-        return parse_shell_command(ctx);
+        result = parse_shell_command(ctx);
+    }
+    else if (is_first(*token, RULE_FUNCDEC))
+    {
+        result = parse_funcdec(ctx);
     }
     else
     {
         perror("Syntax error: unexpected token");
         return NULL;
     }
+
+    return result;
 }
 
 struct ast *parse_simple_command(struct lexer_context *ctx)
 {
     struct list *command_elements = NULL;
+    struct list *redirections = NULL; // list of redirection ASTs
+    struct list *assignments = NULL;
+
+    bool has_prefix = false;
+    struct token *token = PEEK_TOKEN();
+    if (is_first(*token, RULE_PREFIX))
+    {
+        has_prefix = true;
+        while (is_first(*token, RULE_PREFIX))
+        {
+            struct ast *prefix = parse_prefix(ctx);
+            if (prefix == NULL)
+            {
+                return err_s_com(command_elements, redirections, assignments);
+            }
+            if (prefix->type == AST_ASSIGNMENT)
+            {
+                assignments = list_append(assignments, prefix);
+            }
+            else if (prefix->type == AST_REDIR)
+            {
+                redirections = list_append(redirections, prefix);
+            }
+            token = PEEK_TOKEN();
+        }
+    }
 
-    // WORD
-    struct token *token = POP_TOKEN();
     if (token->type != TOKEN_WORD)
     {
-        perror("Expected a command but got a different token type");
-        return NULL;
+        if (!has_prefix && token->type != TOKEN_EXPORT)
+        {
+            perror("Expected a command but got a different token type");
+            return err_s_com(command_elements, redirections, assignments);
+        }
+        if (token->type == TOKEN_EXPORT)
+        {
+            struct ast *assignment_export = parse_export(ctx);
+            if (assignment_export == NULL)
+                return err_s_com(command_elements, redirections, assignments);
+
+            assignments = list_append(assignments, assignment_export);
+        }
     }
-    char *command = strdup(token->data);
-    command_elements = list_append(command_elements, command);
+    else // TOKEN WORD
+    {
+        char *command = strdup(token->data);
+        command_elements = list_append(command_elements, command);
 
+        POP_TOKEN();
+    }
     token = PEEK_TOKEN();
-
     // Eventual elements
     while (is_first(*token, RULE_ELEMENT))
     {
@@ -191,41 +297,40 @@ struct ast *parse_simple_command(struct lexer_context *ctx)
         struct ast *element = parse_element(ctx);
         if (element == NULL)
         {
-            list_deep_destroy(command_elements);
-            return NULL;
+            return err_s_com(command_elements, redirections, assignments);
         }
 
         // Get element type
         if (ast_is_word(element))
         {
+            // Extract word
             struct ast_word *element_word = ast_get_word(element);
-            command_elements =
-                list_append(command_elements, element_word->word);
+            char *word = element_word->word;
+            element_word->word = NULL; // Prevents word to be freed
+            ast_free(&element);
+            command_elements = list_append(command_elements, word);
         }
         else if (ast_is_redir(element))
         {
-            // TODO
-            perror("NOT IMPLEMENTED");
-            return NULL;
+            // append redirections to the list of redirections
+            redirections = list_append(redirections, element);
         }
         else
         {
-            perror("Internal error: unexpected return value from parse_element "
-                   "in parse_simple_command");
-            list_deep_destroy(command_elements);
-            return NULL;
+            perror("Internal error: unexpected return value from "
+                   "parse_element in parse_simple_command");
+            return err_s_com(command_elements, redirections, assignments);
         }
 
         // Forward
         token = PEEK_TOKEN();
     }
 
-    // Result
-    struct ast *result = ast_create_command(command_elements);
+    struct ast *result =
+        ast_create_command(command_elements, redirections, assignments);
     if (result == NULL)
     {
-        list_deep_destroy(command_elements);
-        return NULL;
+        return err_s_com(command_elements, redirections, assignments);
     }
     return result;
 }
@@ -233,15 +338,28 @@ struct ast *parse_simple_command(struct lexer_context *ctx)
 struct ast *parse_element(struct lexer_context *ctx)
 {
     struct token *token = PEEK_TOKEN();
-    if (token->type == TOKEN_WORD)
+    if (token->type == TOKEN_WORD || token->type == TOKEN_ASSIGNMENT_WORD)
     {
-        token = POP_TOKEN();
-        return ast_create_word(token->data);
+        POP_TOKEN();
+
+        struct ast *result = ast_create_word(token->data);
+        if (result == NULL)
+        {
+            perror("Internal error: could not create ast node (is your memory "
+                   "full ?)");
+            return NULL;
+        }
+
+        return result;
     }
     else if (token->type == TOKEN_IONUMBER || is_token_redir(token))
     {
         return parse_redirection(ctx);
     }
+    else if (token->type == TOKEN_EXPORT)
+    {
+        return parse_export(ctx);
+    }
     else
     {
         perror("Syntax error: unexpected token at parse_element");
@@ -251,7 +369,66 @@ struct ast *parse_element(struct lexer_context *ctx)
 
 struct ast *parse_shell_command(struct lexer_context *ctx)
 {
-    return parse_if_rule(ctx);
+    struct token *token = PEEK_TOKEN();
+    struct ast *result = NULL;
+
+    // '{'
+    if (token->type == TOKEN_LEFT_BRACKET)
+    {
+        POP_TOKEN();
+        result = parse_compound_list(ctx);
+        if (result == NULL)
+            return NULL;
+
+        // '}'
+        token = PEEK_TOKEN();
+        if (token->type == TOKEN_LEFT_BRACKET)
+        {
+            ast_free(&result);
+            perror("Syntax error: bracket mismatch");
+            return NULL;
+        }
+
+        POP_TOKEN();
+        return result;
+    }
+    // '('
+    else if (token->type == TOKEN_LEFT_PAREN)
+    {
+        POP_TOKEN();
+        result = parse_compound_list(ctx);
+        if (result == NULL)
+            return NULL;
+
+        // ')'
+        token = PEEK_TOKEN();
+        if (token->type == TOKEN_LEFT_PAREN)
+        {
+            ast_free(&result);
+            perror("Syntax error: parenthesis mismatch");
+            return NULL;
+        }
+        POP_TOKEN();
+        return ast_create_subshell(result);
+    }
+    else if (is_first(*token, RULE_IF))
+    {
+        return parse_if_rule(ctx);
+    }
+    else if (is_first(*token, RULE_WHILE))
+    {
+        return parse_while(ctx);
+    }
+    else if (is_first(*token, RULE_UNTIL))
+    {
+        return parse_until(ctx);
+    }
+    // TODO for and case
+    else
+    {
+        perror("Syntax error: unexpected token in parse_shell_command");
+        return NULL;
+    }
 }
 
 struct ast *parse_if_rule(struct lexer_context *ctx)
@@ -267,55 +444,54 @@ struct ast *parse_if_rule(struct lexer_context *ctx)
 
     // Condition content
     struct ast *condition_content = parse_compound_list(ctx);
+    if (condition_content == NULL)
+        return NULL;
+    token = PEEK_TOKEN();
 
     // Then keyword
-    token = POP_TOKEN();
     if (token->type != TOKEN_THEN)
     {
-        ast_free(&condition_content);
-        perror("Expected the 'then' keyword but token has different type");
-        return NULL;
+        perror("Syntax error: Expected the 'then' keyword but token has "
+               "different type");
+        return err_if_rule(&condition_content, NULL, NULL);
     }
+    POP_TOKEN();
 
     // Then content
     struct ast *then_content = parse_compound_list(ctx);
     if (then_content == NULL)
     {
-        ast_free(&condition_content);
-        ast_free(&then_content);
-        return NULL;
+        return err_if_rule(&condition_content, &then_content, NULL);
     }
+    token = PEEK_TOKEN();
 
+    struct ast *else_content = NULL;
     // Eventual else/elif clause(s)
-    struct ast *else_content = parse_else_clause(ctx);
-    if (else_content == NULL)
+    if (is_first(*token, RULE_ELSE_CLAUSE))
     {
-        ast_free(&condition_content);
-        ast_free(&then_content);
-        return NULL;
+        else_content = parse_else_clause(ctx);
+        if (else_content == NULL)
+        {
+            return err_if_rule(&condition_content, &then_content, NULL);
+        }
+        token = PEEK_TOKEN();
     }
 
     // Fi keyword
-    token = POP_TOKEN();
     if (token->type != TOKEN_FI)
     {
-        ast_free(&condition_content);
-        ast_free(&then_content);
-        ast_free(&else_content);
         perror("Expected the 'fi' keyword but token has different type");
-        return NULL;
+        return err_if_rule(&condition_content, &then_content, &else_content);
     }
+    POP_TOKEN();
 
     // Result
     struct ast *result =
         ast_create_if(condition_content, then_content, else_content);
     if (result == NULL)
     {
-        ast_free(&condition_content);
-        ast_free(&then_content);
-        ast_free(&else_content);
         perror("Internal error: could not create a new AST (AST_IF)");
-        return NULL;
+        return err_if_rule(&condition_content, &then_content, &else_content);
     }
 
     return result;
@@ -330,7 +506,7 @@ struct ast *parse_compound_list(struct lexer_context *ctx)
     // Skip newlines
     while (token->type == TOKEN_NEWLINE)
     {
-        token = POP_TOKEN();
+        POP_TOKEN();
         token = PEEK_TOKEN();
     }
 
@@ -339,9 +515,9 @@ struct ast *parse_compound_list(struct lexer_context *ctx)
     if (current_cmd == NULL)
         return NULL;
     result_list = list_append(result_list, current_cmd);
+    token = PEEK_TOKEN();
 
     // Following commands
-    token = PEEK_TOKEN();
     while (token->type == TOKEN_SEMICOLON || token->type == TOKEN_NEWLINE)
     {
         POP_TOKEN();
@@ -350,7 +526,7 @@ struct ast *parse_compound_list(struct lexer_context *ctx)
         // Skip newlines
         while (token->type == TOKEN_NEWLINE)
         {
-            token = POP_TOKEN();
+            POP_TOKEN();
             token = PEEK_TOKEN();
         }
 
@@ -361,22 +537,21 @@ struct ast *parse_compound_list(struct lexer_context *ctx)
             if (current_cmd == NULL)
                 return NULL;
             result_list = list_append(result_list, current_cmd);
+            token = PEEK_TOKEN();
         }
-
-        token = PEEK_TOKEN();
     }
 
-    // Eventual semicolons
+    // Eventual semicolon
     if (token->type == TOKEN_SEMICOLON)
     {
-        token = POP_TOKEN();
+        POP_TOKEN();
         token = PEEK_TOKEN();
     }
 
     // Skip newlines
     while (token->type == TOKEN_NEWLINE)
     {
-        token = POP_TOKEN();
+        POP_TOKEN();
         token = PEEK_TOKEN();
     }
 
@@ -399,25 +574,37 @@ struct ast *parse_else_clause(struct lexer_context *ctx)
         token = POP_TOKEN();
         if (token->type != TOKEN_THEN)
         {
-            perror(
-                "Expected the 'then' keyword but got a different token type");
+            perror("Expected the 'then' keyword but got a different token "
+                   "type");
             return NULL;
         }
 
-        // Then clause
         struct ast *then_content = parse_compound_list(ctx);
+        if (then_content == NULL)
+        {
+            ast_free(&condition);
+            return NULL;
+        }
+        token = PEEK_TOKEN();
 
         // Eventual else clause (recursive)
         struct ast *else_content = NULL;
-        token = PEEK_TOKEN();
         if (token->type == TOKEN_ELSE || token->type == TOKEN_ELIF)
         {
             else_content = parse_else_clause(ctx);
+            if (else_content == NULL)
+            {
+                ast_free(&then_content);
+                ast_free(&condition);
+                return NULL;
+            }
+        }
+        else
+        {
+            else_content = ast_create_void();
         }
 
-        struct ast *result =
-            ast_create_if(condition, then_content, else_content);
-        return result;
+        return ast_create_if(condition, then_content, else_content);
     }
 
     // Eventual else content
@@ -426,12 +613,15 @@ struct ast *parse_else_clause(struct lexer_context *ctx)
 
     if (token->type == TOKEN_ELSE)
     {
-        token = POP_TOKEN(); // eat else
+        token = POP_TOKEN();
         result = parse_compound_list(ctx);
+        if (result == NULL)
+            return NULL;
     }
-
-    if (result == NULL)
+    else
+    {
         result = ast_create_void();
+    }
 
     return result;
 }

src/parser/grammar_basic.h

@@ -43,6 +43,7 @@ struct ast *parse_pipeline(struct lexer_context *ctx);
  *
  * @code command = simple_command
  *               | shell_command
+ *
  *               ;
  * @first first(simple_command), first(shell_command)
  */
@@ -72,7 +73,10 @@ struct ast *parse_element(struct lexer_context *ctx);
 /*
  * @brief Only parses if rules for the moment
  *
- * @code shell_command = if_rule ;
+ * @code shell_command = '{' compound_list '}'
+ *                     | '(' compound_list ')'
+ *                     | if_rule
+ *                     ;
  *
  * @first first(if_rule)
  */
@@ -99,7 +103,7 @@ struct ast *parse_if_rule(struct lexer_context *ctx);
 struct ast *parse_compound_list(struct lexer_context *ctx);
 
 /*
- * @brief
+ * @brief parses an else clause rule (inside if)
  *
  * @code else_clause = 'else' compound_list
  *                   | 'elif' compound_list 'then' compound_list [else_clause]

src/parser/parser.c

@@ -10,12 +10,12 @@ static enum parser_state state = PARSER_STATE_NOT_INITIALIZED;
 
 // === Functions
 
-bool parser_init(void)
+int parser_init(void)
 {
     if (state == PARSER_STATE_READY)
     {
         perror("Internal error: tried to initialize the parser module twice.");
-        return NULL;
+        return false;
     }
     int success = grammar_init();
     if (success == false)

src/parser/parser.h

@@ -18,7 +18,7 @@ enum parser_state
  *
  * @return Returns false on error and true on success
  */
-bool parser_init(void);
+int parser_init(void);
 
 /* @brief Closes the parser module after use
  */

src/utils/Makefile.am

@@ -17,8 +17,13 @@ libutils_a_SOURCES =  \
 	ast/ast_word.c \
 	ast/ast_neg.c \
 	ast/ast_pipe.c \
+	ast/ast_loop.c \
 	args/args.c \
-	vars/vars.c
+	vars/vars.c \
+	main_loop/main_loop.c \
+	ast/ast_assignment.c \
+	ast/ast_subshell.c \
+	ast/ast_function.c
 
 libutils_a_CPPFLAGS = -I$(top_srcdir)/src
 

src/utils/args/args.c

@@ -67,7 +67,7 @@ int args_handler(int argc, char **argv, struct args_options *options,
 {
     options->type = INPUT_UNDEFINED;
     options->input_source = NULL;
-    options->pretty_print = false;
+    // options->pretty_print = false;
     options->verbose = false;
 
     struct list *args_list = NULL;
@@ -76,11 +76,11 @@ int args_handler(int argc, char **argv, struct args_options *options,
 
     for (int i = 1; i < argc; i++)
     {
-        if (strcmp(argv[i], "--pretty-print") == 0)
+        /* if (strcmp(argv[i], "--pretty-print") == 0)
         {
             options->pretty_print = true;
-        }
-        else if (strcmp(argv[i], "--verbose") == 0)
+        } */
+        if (strcmp(argv[i], "--verbose") == 0)
         {
             options->verbose = true;
         }
@@ -121,7 +121,7 @@ int args_handler(int argc, char **argv, struct args_options *options,
     }
 
     args_in_var(vars, args_list);
-    list_destroy(args_list);
+    list_destroy(&args_list);
 
     if (options->type == INPUT_UNDEFINED)
         options->type = INPUT_STDIN;
@@ -138,7 +138,7 @@ void args_print(struct args_options *options)
                                               : "UNDEFINED");
     printf("Input source: %s\n",
            options->input_source ? options->input_source : "NULL");
-    printf("Pretty print: %s\n", options->pretty_print ? "true" : "false");
+    // printf("Pretty print: %s\n", options->pretty_print ? "true" : "false");
     printf("Verbose: %s\n", options->verbose ? "true" : "false");
 }
 
@@ -147,7 +147,8 @@ void print_usage(FILE *std, const char *program_name)
     fprintf(std, "Usage: %s [OPTIONS] [SCRIPT] [ARGUMENTS...]\n", program_name);
     fprintf(std, "Options:\n");
     fprintf(std, "  -c [SCRIPT]        Execute the given command string.\n");
-    fprintf(std, "  --pretty-print     Enable pretty printing of outputs.\n");
+    // fprintf(std, "  --pretty-print     Enable pretty printing of
+    // outputs.\n");
     fprintf(std, "  --verbose          Enable verbose mode.\n");
     fprintf(std,
             "If no SCRIPT is provided, input is read from standard input.\n");

src/utils/args/args.h

@@ -22,7 +22,7 @@ struct args_options
     /** Type of the input source */
     enum input_type type;
     /** Enable or disable pretty printing of outputs */
-    bool pretty_print;
+    // bool pretty_print;
     /** Enable or disable verbose mode */
     bool verbose;
 };

src/utils/ast/ast.c

@@ -11,7 +11,7 @@ void ast_free(struct ast **node)
 {
     if (node == NULL || *node == NULL)
     {
-        perror(
+        fprintf(stderr,
             "WARNING: Internal error: failed to free AST node (NULL argument)");
         return;
     }
@@ -39,14 +39,28 @@ void ast_free(struct ast **node)
     case AST_WORD:
         ast_free_word(ast_get_word(*node));
         break;
-
+    case AST_ASSIGNMENT:
+        ast_free_assignment(ast_get_assignment(*node));
+        break;
+    case AST_NEG:
+        ast_free_neg(ast_get_neg(*node));
+        break;
+    case AST_LOOP:
+        ast_free_loop(ast_get_loop(*node));
+        break;
+    case AST_FUNCTION:
+        ast_free_function(ast_get_function(*node));
+        break;
+    case AST_SUBSHELL:
+        ast_free_subshell(ast_get_subshell(*node));
+        break;
     case AST_VOID:
     case AST_END:
         break;
 
     default:
-        perror("WARNING: Internal error: failed to free an AST node (Unknown "
-               "type)");
+        fprintf(stderr, "WARNING: Internal error:"
+                " failed to free an AST node (Unknown type)");
         return;
     }
 
@@ -66,7 +80,7 @@ struct ast *ast_create(enum ast_type type, void *data)
     return node;
 }
 
-// TODO handle new types (AST_WORD, AST_PIPE, etc.)
+/* // TODO handle new types (AST_WORD, AST_PIPE, etc.)
 static void ast_print_dot_recursive(struct ast *node, FILE *out)
 {
     if (!node)
@@ -157,3 +171,4 @@ void ast_print_dot(struct ast *ast)
     fprintf(dot_pipe, "}\n");
     pclose(dot_pipe);
 }
+ */

src/utils/ast/ast.h

@@ -2,20 +2,19 @@
 #define AST_H
 
 #include "ast_and_or.h"
+#include "ast_assignment.h"
 #include "ast_base.h"
 #include "ast_command.h"
 #include "ast_end.h"
+#include "ast_function.h"
 #include "ast_if.h"
 #include "ast_list.h"
+#include "ast_loop.h"
 #include "ast_neg.h"
 #include "ast_pipe.h"
 #include "ast_redir.h"
 #include "ast_void.h"
 #include "ast_word.h"
-
-/**
- * Prints the Graphviz DOT representation of the given AST to stdout.
- */
-void ast_print_dot(struct ast *ast);
+#include "ast_subshell.h"
 
 #endif /* ! AST_H */

src/utils/ast/ast_assignment.c

@@ -0,0 +1,56 @@
+#define _POSIX_C_SOURCE 200809L
+
+#include "ast_assignment.h"
+
+#include <stdlib.h>
+#include <string.h>
+
+bool ast_is_assignment(struct ast *node)
+{
+    return node != NULL && node->type == AST_ASSIGNMENT;
+}
+
+struct ast_assignment *ast_get_assignment(struct ast *node)
+{
+    if (node == NULL || node->type != AST_ASSIGNMENT)
+        return NULL;
+    return (struct ast_assignment *)node->data;
+}
+
+/* @brief: splits the assignement 'name=value' into 2 parts,
+ *      and fills the fields of ast_assignment with it.
+ */
+static void init_assignments(struct ast_assignment *ast_assignment,
+                             char *assignment)
+{
+    if (assignment == NULL)
+        return;
+    char *split_pos = strchr(assignment, '=');
+    if (split_pos == NULL)
+        return;
+
+    *split_pos = '\0';
+    ast_assignment->name = strdup(assignment);
+    ast_assignment->value = strdup(split_pos + 1);
+}
+
+struct ast *ast_create_assignment(char *assignment, bool global)
+{
+    struct ast_assignment *assignment_data =
+        calloc(1, sizeof(struct ast_assignment));
+    if (!assignment_data)
+        return NULL;
+
+    init_assignments(assignment_data, assignment);
+    assignment_data->global = global;
+    return ast_create(AST_ASSIGNMENT, assignment_data);
+}
+
+void ast_free_assignment(struct ast_assignment *assignment_data)
+{
+    if (assignment_data == NULL)
+        return;
+    free(assignment_data->name);
+    free(assignment_data->value);
+    free(assignment_data);
+}

src/utils/ast/ast_assignment.h

@@ -0,0 +1,18 @@
+#ifndef AST_ASSIGNMENT_H
+#define AST_ASSIGNMENT_H
+
+#include "ast_base.h"
+
+struct ast_assignment
+{
+    char *name;
+    char *value;
+    bool global;
+};
+
+bool ast_is_assignment(struct ast *node);
+struct ast_assignment *ast_get_assignment(struct ast *node);
+struct ast *ast_create_assignment(char *assignment, bool global);
+void ast_free_assignment(struct ast_assignment *assignment_data);
+
+#endif /* ! AST_ASSIGNMENT_H */

src/utils/ast/ast_base.h

@@ -15,7 +15,11 @@ enum ast_type
     AST_CMD,
     AST_WORD,
     AST_PIPE,
-    AST_NEG
+    AST_NEG,
+    AST_LOOP,
+    AST_ASSIGNMENT,
+    AST_FUNCTION,
+    AST_SUBSHELL
 };
 
 struct ast

src/utils/ast/ast_command.c

@@ -4,14 +4,18 @@
 #include <stdlib.h>
 
 #include "../lists/lists.h"
+#include "ast_list.h"
 
-struct ast *ast_create_command(struct list *command)
+struct ast *ast_create_command(struct list *command, struct list *redirections,
+                               struct list *assignments)
 {
     struct ast_command *command_data = malloc(sizeof(struct ast_command));
     if (!command_data)
         return NULL;
 
     command_data->command = command;
+    command_data->redirections = redirections;
+    command_data->assignments = assignments;
 
     return ast_create(AST_CMD, command_data);
 }
@@ -33,5 +37,7 @@ void ast_free_command(struct ast_command *command_data)
     if (command_data == NULL)
         return;
     list_deep_destroy(command_data->command);
+    ast_list_deep_destroy(command_data->redirections);
+    ast_list_deep_destroy(command_data->assignments);
     free(command_data);
 }

src/utils/ast/ast_command.h

@@ -7,6 +7,8 @@
 struct ast_command
 {
     struct list *command; // A list of words (char*)
+    struct list *redirections; // A list of ASTs, all ast_redir
+    struct list *assignments; // A list of ASTs, all ast_assignment
 };
 
 /**
@@ -23,7 +25,8 @@ struct ast_command *ast_get_command(struct ast *node);
 /**
  * Creates a new AST node representing a command.
  */
-struct ast *ast_create_command(struct list *command);
+struct ast *ast_create_command(struct list *command, struct list *redirections,
+                               struct list *assignments);
 
 /*
  * @brief: frees the given ast_command and sets the pointer to NULL.

src/utils/ast/ast_function.c

@@ -0,0 +1,42 @@
+#include "ast_function.h"
+
+#include <stdlib.h>
+#include <string.h>
+
+#include "ast_base.h"
+
+bool ast_is_function(struct ast *node)
+{
+    return node != NULL && node->type == AST_FUNCTION;
+}
+
+struct ast_function *ast_get_function(struct ast *node)
+{
+    if (!ast_is_function(node))
+        return NULL;
+    return (struct ast_function *)node->data;
+}
+
+struct ast *ast_create_function(char *name, struct ast *value)
+{
+    struct ast_function *function_data = malloc(sizeof(struct ast_function));
+    if (!function_data)
+        return NULL;
+
+    function_data->name = name;
+    function_data->value = value;
+
+    return ast_create(AST_FUNCTION, function_data);
+}
+
+void ast_free_function(struct ast_function *function_data)
+{
+    if (function_data)
+    {
+        free(function_data->name);
+        // WARNING: this ast will be stored in the function hashmap.
+        // thus, it will be freed from the hashmap.
+        // ast_free(&function_data->value);
+        free(function_data);
+    }
+}

src/utils/ast/ast_function.h

@@ -0,0 +1,33 @@
+#ifndef AST_FUNCTION_H
+#define AST_FUNCTION_H
+
+#include <stdbool.h>
+
+struct ast_function
+{
+    char *name;
+    struct ast *value;
+};
+
+/**
+ * @brief: Checks if the given AST node is an ast_function
+ */
+bool ast_is_function(struct ast *node);
+
+/**
+ * @brief: Retrieves the function data from the given AST node.
+ *         Assumes that the node is of type AST_function.
+ */
+struct ast_function *ast_get_function(struct ast *node);
+
+/**
+ * @brief: Creates a new AST node representing an AST_function
+ * @warning: name must be already allocated.
+ */
+struct ast *ast_create_function(char *name, struct ast *value);
+/*
+ * @brief: frees the given ast_function and sets the pointer to NULL.
+ */
+void ast_free_function(struct ast_function *function_data);
+
+#endif /* AST_FUNCTION_H */

src/utils/ast/ast_if.c

@@ -19,7 +19,7 @@ struct ast *ast_create_if(struct ast *condition, struct ast *then_clause,
 
 struct ast_if *ast_get_if(struct ast *node)
 {
-    if (node == NULL || node->type == AST_IF)
+    if (node == NULL || node->type != AST_IF)
         return NULL;
     return node->data;
 }

src/utils/ast/ast_loop.c

@@ -0,0 +1,37 @@
+#include "ast_loop.h"
+
+#include <stdbool.h>
+#include <stdlib.h>
+
+struct ast *ast_create_loop(struct ast *condition, struct ast *body)
+{
+    struct ast_loop *node_data = malloc(sizeof(struct ast_loop));
+    if (!node_data)
+        return NULL;
+
+    node_data->condition = condition;
+    node_data->body = body;
+
+    return ast_create(AST_LOOP, node_data);
+}
+
+struct ast_loop *ast_get_loop(struct ast *node)
+{
+    if (node == NULL || node->type != AST_LOOP)
+        return NULL;
+    return (struct ast_loop *)node->data;
+}
+
+bool ast_is_loop(struct ast *node)
+{
+    return node != NULL && node->type == AST_LOOP;
+}
+
+void ast_free_loop(struct ast_loop *loop_data)
+{
+    if (loop_data == NULL)
+        return;
+    ast_free(&loop_data->condition);
+    ast_free(&loop_data->body);
+    free(loop_data);
+}

src/utils/ast/ast_loop.h

@@ -0,0 +1,34 @@
+#ifndef AST_LOOP_H
+#define AST_LOOP_H
+
+#include "ast_base.h"
+
+struct ast_loop
+{
+    // Repeat body while condition is true
+    struct ast *condition;
+    struct ast *body;
+};
+
+/**
+ * Checks if the given AST node is a loop.
+ */
+bool ast_is_loop(struct ast *node);
+
+/**
+ * Retrieves the loop data from the given AST node.
+ * Assumes that the node is of type AST_LOOP.
+ */
+struct ast_loop *ast_get_loop(struct ast *node);
+
+/**
+ * Creates a new AST node representing a loop.
+ */
+struct ast *ast_create_loop(struct ast *condition, struct ast *body);
+
+/*
+ * @brief: frees the given ast_loop and sets the pointer to NULL.
+ */
+void ast_free_loop(struct ast_loop *loop_node);
+
+#endif /* ! AST_LOOP_H */

src/utils/ast/ast_redir.h

@@ -8,7 +8,7 @@ enum ast_redir_type
     AST_REDIR_TYPE_NULL,
     AST_REDIR_TYPE_LESS, // <
     AST_REDIR_TYPE_GREAT, // >
-    AST_REDIR_TYPE_DLESS, // <<
+    AST_REDIR_TYPE_LESSGREAT, // <>
     AST_REDIR_TYPE_DGREAT, // >>
     AST_REDIR_TYPE_LESSAND, // <&
     AST_REDIR_TYPE_GREATAND, // >&
@@ -21,6 +21,7 @@ struct ast_redir
     int io_number; // The FD being redirected (default -1 if not specified,
                    // implies 0 or 1 based on type)
     enum ast_redir_type type;
+    int saved_fd; // To store the original FD for restoration (-1 before save)
 };
 
 bool ast_is_redir(struct ast *node);

src/utils/ast/ast_subshell.c

@@ -0,0 +1,31 @@
+#include "ast_subshell.h"
+
+bool ast_is_subshell(struct ast *node)
+{
+    return node != NULL && node->type == AST_SUBSHELL;
+}
+
+struct ast_subshell *ast_get_subshell(struct ast *node)
+{
+    if (ast_is_subshell(node))
+        return (struct ast_subshell *)node->data;
+    return NULL;
+}
+
+struct ast *ast_create_subshell(struct ast *child)
+{
+    struct ast_subshell *subshell = calloc(1, sizeof(struct ast_subshell));
+    if (subshell == NULL)
+        return NULL;
+    subshell->child = child;
+
+    return ast_create(AST_SUBSHELL, subshell);
+}
+
+void ast_free_subshell(struct ast_subshell *subshell)
+{
+    if (!subshell)
+        return;
+    ast_free(&subshell->child);
+    free(subshell);
+}

src/utils/ast/ast_subshell.h

@@ -0,0 +1,19 @@
+#ifndef AST_SUBSHELL_H
+#define AST_SUBSHELL_H
+
+#include "ast_base.h"
+
+struct ast_subshell
+{
+    struct ast *child;
+};
+
+bool ast_is_subshell(struct ast *node);
+
+struct ast_subshell *ast_get_subshell(struct ast *node);
+
+struct ast *ast_create_subshell(struct ast *child);
+
+void ast_free_subshell(struct ast_subshell *subshell);
+
+#endif /* ! AST_SUBSHELL_H */

src/utils/ast/ast_word.c

@@ -2,7 +2,6 @@
 #include "ast_word.h"
 
 #include <stdbool.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
@@ -43,6 +42,8 @@ void ast_free_word(struct ast_word *ast_node)
     if (ast_node == NULL)
         return;
 
-    free(ast_node->word);
+    if (ast_node->word != NULL)
+        free(ast_node->word);
+
     free(ast_node);
 }

src/utils/hash_map/hash_map.c

@@ -7,6 +7,8 @@
 #include <stdlib.h>
 #include <string.h>
 
+#include "../ast/ast.h"
+
 /*
 ** Hash the key using FNV-1a 32 bits hash algorithm.
 */
@@ -36,6 +38,14 @@ static void destroy_pair_list(struct pair_list **p)
     *p = NULL;
 }
 
+static void destroy_pair_list_ast(struct pair_list **p)
+{
+    free((char *)(*p)->key);
+    ast_free((*p)->value);
+    free((*p));
+    *p = NULL;
+}
+
 struct hash_map *hash_map_init(size_t size)
 {
     struct hash_map *p = malloc(sizeof(struct hash_map));
@@ -116,6 +126,30 @@ void hash_map_free(struct hash_map **hash_map)
         }
         free((*hash_map)->data);
         free(*hash_map);
+        *hash_map = NULL;
+    }
+}
+
+void hash_map_free_ast(struct hash_map **hash_map)
+{
+    struct pair_list *l;
+    struct pair_list *prev;
+
+    if (hash_map != NULL && *hash_map != NULL)
+    {
+        for (size_t i = 0; i < (*hash_map)->size; i++)
+        {
+            l = (*hash_map)->data[i];
+            while (l != NULL)
+            {
+                prev = l;
+                l = l->next;
+                destroy_pair_list_ast(&prev);
+            }
+        }
+        free((*hash_map)->data);
+        free(*hash_map);
+        *hash_map = NULL;
     }
 }
 

src/utils/lists/lists.h

@@ -31,7 +31,7 @@ void list_print(struct list *list);
 ** Release the memory used by the list.
 ** Does nothing if `list` is `NULL`.
 */
-void list_destroy(struct list *list);
+void list_destroy(struct list **list);
 
 /*
 ** Release the memory used by the list and its content

src/utils/lists/lists1.c

@@ -49,9 +49,9 @@ void list_print(struct list *list)
     }
 }
 
-void list_destroy(struct list *list)
+void list_destroy(struct list **list)
 {
-    struct list *elt = list;
+    struct list *elt = *list;
     struct list *next_elt;
     while (elt != NULL)
     {
@@ -59,6 +59,7 @@ void list_destroy(struct list *list)
         free(elt);
         elt = next_elt;
     }
+    *list = NULL;
 }
 
 struct list *list_append(struct list *list, void *value)

src/utils/main_loop/main_loop.c

@@ -0,0 +1,111 @@
+#define _POSIX_C_SOURCE 200809L
+
+#include "main_loop.h"
+
+// === Includes
+#include <stdio.h>
+#include <string.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <sys/types.h>
+#include <sys/wait.h>
+
+#include "../../execution/execution.h"
+#include "../../io_backend/io_backend.h"
+#include "../../lexer/lexer.h"
+#include "../../parser/parser.h"
+#include "../args/args.h"
+#include "../vars/vars.h"
+
+// === Functions
+
+int err_input(struct hash_map **vars, struct lexer_context *ctx)
+{
+    hash_map_free(vars);
+    destroy_lexer_context(ctx);
+    return ERR_INPUT_PROCESSING;
+}
+
+int main_loop(struct lexer_context *ctx, struct hash_map *vars)
+{
+    int return_code = SUCCESS;
+
+    // Retrieve and build first AST
+    struct ast *command_ast = get_ast(ctx);
+
+    // Main parse-execute loop
+    while (command_ast != NULL && command_ast->type != AST_END)
+    {
+        if (command_ast->type != AST_VOID)
+        {
+            // Execute AST
+            return_code = execution(command_ast, vars);
+
+            // set $? variable
+            set_var_int(vars, "?", return_code);
+        }
+
+        ast_free(&command_ast);
+
+        // Retrieve and build next AST
+        command_ast = get_ast(ctx);
+    }
+
+    if (command_ast == NULL)
+        return err_input(&vars, ctx);
+
+    // === free
+
+    ast_free(&command_ast);
+    hash_map_free(&vars);
+    destroy_lexer_context(ctx);
+
+    return return_code;
+}
+
+/* @brief: initializes a lexer context from a command string.
+ * @return: pointer to the lexer context, or NULL on failure.
+ */
+static struct lexer_context *lexer_init_from_string(char *command)
+{
+    // Create a lexer context from the command string
+    struct lexer_context *ctx = calloc(1, sizeof(struct lexer_context));
+    if (ctx == NULL)
+        return NULL;
+
+    ctx->end_previous_token = strdup(command);
+    if (ctx->end_previous_token == NULL)
+    {
+        free(ctx);
+        return NULL;
+    }
+    ctx->remaining_chars = strlen(command);
+
+    return ctx;
+}
+
+int start_subshell(struct hash_map **parent_vars, char *command)
+{
+    int fd = fork();
+    if (fd < 0)
+        return ERR_GENERIC;
+
+    else if (fd == 0) // Child process
+    {
+        struct lexer_context *ctx = lexer_init_from_string(command);
+        if (ctx == NULL)
+            return ERR_MALLOC;
+        int return_code = main_loop(ctx, *parent_vars);
+        exit(return_code);
+    }
+    else // Parent process
+    {
+        int status;
+        if (waitpid(fd, &status, 0) == -1)
+            return ERR_GENERIC;
+        if (WIFEXITED(status))
+            return WEXITSTATUS(status);
+        else
+            return ERR_GENERIC;
+    }
+}

src/utils/main_loop/main_loop.h

@@ -0,0 +1,31 @@
+#ifndef MAIN_LOOP_H
+#define MAIN_LOOP_H
+
+#include "../../utils/vars/vars.h"
+#include "../../lexer/lexer.h"
+
+// === Error codes
+#define SUCCESS 0
+#define ERR_INPUT_PROCESSING 2
+#define ERR_MALLOC 3
+#define ERR_GENERIC 4
+
+/* @brief: main loop called from main.
+ * @return: exit code.
+ */
+int main_loop(struct lexer_context *ctx, struct hash_map *vars);
+
+/*
+ * @brief: frees the hash map and lexer context.
+ * @return: ERR_INPUT_PROCESSING.
+ */
+int err_input(struct hash_map **vars, struct lexer_context *ctx);
+
+/*
+ * @brief: starts a subshell and builds the intern lexer context
+ * from the string.
+ * @return: exit code of the subshell.
+ */
+int start_subshell(struct hash_map **parent_vars, char *command);
+
+#endif /* MAIN_LOOP_H */

tests/functional/and_ors.sh

@@ -0,0 +1,17 @@
+true
+echo 'true =' $?
+
+false
+echo 'false =' $?
+
+false && true
+echo 'false && true =' $?
+
+true && false
+echo 'true && false =' $?
+
+true || false
+echo 'true || false =' $?
+
+false || true
+echo 'false || true =' $?

tests/functional/func.sh

@@ -0,0 +1,21 @@
+func()
+{
+    echo hello
+}
+
+arg_func()
+{
+    echo first argument is "$1"
+}
+
+func_in_func()
+{
+    func
+}
+
+func_one_line() { echo "this is on one line"; }
+
+func
+arg_func "HERE"
+func_in_func
+func_one_line

tests/functional/loops.sh

@@ -0,0 +1,20 @@
+echo "starting tests"
+
+while false;
+do
+    echo "should NOT be printed"
+done
+
+a='yes'
+while [ "$a" -eq "yes" ];
+do
+    a="no"
+    echo "should be printed only once"
+done;
+
+while true;
+do
+    echo "yes"
+done;
+
+echo "tests done"

tests/functional/run-tests.sh

@@ -251,7 +251,7 @@ summarize() {
 
     # Print
     echo -e $BWhite "\n\n""===========" $UWhite"Summary"$Color_Off "\n"
-    echo -e " Passed $coverage_color$passed_tests/$total_tests$Color_Off tests ($coverage_color$tests_percentage$Color_Off%)"
+    echo -e " Passed $coverage_color$passed_tests/$total_tests$Color_Off tests ($coverage_color$tests_percentage%$Color_Off)"
     echo -e " Got $timeouts_color$timeouts_count timeout(s)$Color_Off"
     if [ "$OUTPUT_FILE" != "" ]; then
         echo $tests_percentage > "$OUTPUT_FILE";
@@ -269,9 +269,6 @@ echo -e "\n\n""===$BGreen TestsuitatorX Ultra Pro Max+ 365 Premium Gris Sidéral
 
 
 
-
-#
-
 echo -e "\n$BBlue=== Builtins ===$Color_Off"
 # echo
 test_str "Hello" "echo Hello"
@@ -377,9 +374,14 @@ test_str "If with negation" "if ! false; then echo Yes; fi"
 test_str "If faut aller niquer sa mere" "if false; ! false; then echo Embrasse moi; fi"
 
 
-echo -e "\n$BBlue=== For/While ===$Color_Off"
-test_str "While loop" "i=0; while [ \$i -lt 3 ]; do echo \$i; i=\$((i+1)); done"
-test_str "Until loop" "i=0; until [ \$i -ge 3 ]; do echo \$i; i=\$((i+1)); done"
+echo -e "\n$BBlue=== Loops ===$Color_Off"
+test_str "While false" "while false; do false; done"
+test_str "While(false) true" "while false; do true; done"
+test_str "Until(true) false" "until true; do false; done"
+test_str "Until true" "until true; do true; done"
+# test_str "While var" "a=2; while [ \$a -eq 2 ]; do \$a=3; done"
+test_str "While arithmetic" "i=0; while [ \$i -lt 3 ]; do echo \$i; i=\$((i+1)); done"
+test_str "Until arithmetic" "i=0; until [ \$i -ge 3 ]; do echo \$i; i=\$((i+1)); done"
 test_str "While break" "while true; do echo break; break; done"
 test_str "While continue" "i=0; while [ \$i -lt 3 ]; do i=\$((i+1)); if [ \$i -eq 2 ]; then continue; fi; echo \$i; done"
 test_str "For loop basic" "for i in a b c; do echo \$i; done"

tests/unit/expansion/expand.c

@@ -1,7 +1,6 @@
 #define _POSIX_C_SOURCE 200809L
 #include <criterion/criterion.h>
 #include <criterion/new/assert.h>
-#include <criterion/redirect.h>
 #include <stdlib.h>
 #include <unistd.h>
 
@@ -17,7 +16,7 @@ Test(expand, no_expansion)
     char str[] = "echo something";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     bool ret = expand(ast_command, NULL);
@@ -32,7 +31,7 @@ Test(expand, single_quotes_no_expansion)
     char str[] = "echo '$VAR'";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -51,7 +50,7 @@ Test(expand, single_dollar)
     char str[] = "echo $ sign";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -70,7 +69,7 @@ Test(expand, empty_braces_no_expansion)
     char str[] = "echo ${}";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -87,7 +86,7 @@ Test(expand, basic_expansion)
     char str[] = "echo $VAR";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -106,7 +105,7 @@ Test(expand, multiple_expansion)
     char str[] = "echo $VAR1 $VAR2 ${VAR3}";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -128,7 +127,7 @@ Test(expand, env_variable)
     char str[] = "echo $MY_ENV_VAR";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     setenv("MY_ENV_VAR", "environment", 0);
@@ -145,7 +144,7 @@ Test(expand, undefined_variable)
     char str[] = "echo $UNDEFINED";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -163,7 +162,7 @@ Test(expand, nested_expansion)
     char str[] = "echo $B";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -178,34 +177,34 @@ Test(expand, nested_expansion)
     hash_map_free(&vars);
 }
 
-Test(expand, mixed_quotes_expansion)
-{
-    char str[] = "echo \"$VAR1 and '$VAR2'\"";
-    char *str_heap = strdup(str);
-    struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
-    struct ast_command *ast_command = ast_get_command(ast);
+// Test(expand, mixed_quotes_expansion)
+// {
+//     char str[] = "echo \"$VAR1 and '$VAR2'\"";
+//     char *str_heap = strdup(str);
+//     struct list *list = list_append(NULL, str_heap);
+//     struct ast *ast = ast_create_command(list, NULL, NULL);
+//     struct ast_command *ast_command = ast_get_command(ast);
 
-    struct hash_map *vars = vars_init();
-    set_var_copy(vars, "VAR1", "expanded");
-    set_var_copy(vars, "VAR2", "not_expanded");
+//     struct hash_map *vars = vars_init();
+//     set_var_copy(vars, "VAR1", "expanded");
+//     set_var_copy(vars, "VAR2", "not_expanded");
 
-    bool ret = expand(ast_command, vars);
-    cr_expect(ret, "expansion failed with %s", str);
-    cr_expect_str_eq((char *)ast_command->command->data,
-                     "echo \"expanded and $VAR2\"",
-                     "Variable in double quotes should expand, while variable "
-                     "in single quotes should not");
-    ast_free(&ast);
-    hash_map_free(&vars);
-}
+//     bool ret = expand(ast_command, vars);
+//     cr_expect(ret, "expansion failed with %s", str);
+//     cr_expect_str_eq((char *)ast_command->command->data,
+//                      "echo \"expanded and $VAR2\"",
+//                      "Variable in double quotes should expand, while variable "
+//                      "in single quotes should not");
+//     ast_free(&ast);
+//     hash_map_free(&vars);
+// }
 
 Test(expand, adjacent_variables)
 {
     char str[] = "echo $VAR1$VAR2";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -225,7 +224,7 @@ Test(expand, random)
     char str[] = "$RANDOM";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     bool ret = expand(ast_command, NULL);
@@ -241,7 +240,7 @@ Test(expand, pid)
     char str[] = "$$";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();
@@ -259,7 +258,7 @@ Test(expand, default_last_exit_code)
     char str[] = "$?";
     char *str_heap = strdup(str);
     struct list *list = list_append(NULL, str_heap);
-    struct ast *ast = ast_create_command(list);
+    struct ast *ast = ast_create_command(list, NULL, NULL);
     struct ast_command *ast_command = ast_get_command(ast);
 
     struct hash_map *vars = vars_init();

tests/unit/expansion/parse_subshell.c

@@ -0,0 +1,72 @@
+#include <criterion/criterion.h>
+#include <criterion/new/assert.h>
+
+#include "../../../src/expansion/expansion.h"
+
+TestSuite(parse_subshell_str);
+
+Test(parse_subshell_str, basic_subshell)
+{
+    char *input = "(ls -l)";
+    char *extracted_var = NULL;
+    size_t r = parse_subshell_str(input, &extracted_var);
+
+    cr_expect(r == 7);
+    cr_expect_str_eq(extracted_var, "ls -l");
+    free(extracted_var);
+}
+
+Test(parse_subshell_str, multi_basic_subshell)
+{
+    char *input = "(echo hello) and (echo world)";
+    char *extracted_var = NULL;
+    size_t r = parse_subshell_str(input, &extracted_var);
+
+    cr_expect(r == 12);
+    cr_expect_str_eq(extracted_var, "echo hello");
+    free(extracted_var);
+
+    input += r + 5; // skip " and "
+    r = parse_subshell_str(input, &extracted_var);
+
+    cr_expect(r == 12);
+    cr_expect_str_eq(extracted_var, "echo world");
+    free(extracted_var);
+}
+
+Test(parse_subshell_str, incomplete_braces)
+{
+    char *input = "(echo hello";
+    char *extracted_var = NULL;
+    size_t r = parse_subshell_str(input, &extracted_var);
+
+    cr_expect(r == 0);
+    cr_expect(extracted_var == NULL);
+}
+
+Test(parse_subshell_str, empty_braces)
+{
+    char *input = "()";
+    char *extracted_var = NULL;
+    size_t r = parse_subshell_str(input, &extracted_var);
+
+    cr_expect(r == 0);
+    cr_expect(extracted_var == NULL);
+}
+
+Test(parse_subshell_str, nested_subshell)
+{
+    char *input = "(echo (nested))";
+    char *extracted_var = NULL;
+    size_t r = parse_subshell_str(input, &extracted_var);
+
+    cr_expect(r == 15);
+    cr_expect_str_eq(extracted_var, "echo (nested)");
+    free(extracted_var);
+
+    char *nested = input + 6; // point to the nested subshell
+    r = parse_subshell_str(nested, &extracted_var);
+    cr_expect(r == 8);
+    cr_expect_str_eq(extracted_var, "nested");
+    free(extracted_var);
+}

tests/unit/expansion/parse_var.c

@@ -1,6 +1,5 @@
 #include <criterion/criterion.h>
 #include <criterion/new/assert.h>
-#include <criterion/redirect.h>
 
 #include "../../../src/expansion/expansion.h"
 

tests/unit/utils/args.c

@@ -19,7 +19,7 @@ Test(utils_args, basic_command)
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    cr_expect(options.pretty_print == false);
+    // cr_expect(options.pretty_print == false);
     cr_expect(options.verbose == false);
     cr_expect(options.type == INPUT_CMD);
     cr_expect(eq(options.input_source, "echo Hello, World!"));
@@ -30,14 +30,16 @@ Test(utils_args, basic_command_with_flags)
 {
     int argc = 5;
     struct args_options options;
-    char *input[] = { "program", "--pretty-print", "-c", "echo Hello, World!",
-                      "--verbose" };
+    /* char *input[] = { "program", "--pretty-print", "-c", "echo Hello,
+       World!",
+                      "--verbose" };*/
+    char *input[] = { "program", "-c", "echo Hello, World!", "--verbose" };
 
     struct hash_map *vars = vars_init();
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    cr_expect(options.pretty_print == true);
+    // cr_expect(options.pretty_print == true);
     cr_expect(options.verbose == true);
     cr_expect(options.type == INPUT_CMD);
     cr_expect(eq(options.input_source, "echo Hello, World!"));
@@ -54,7 +56,7 @@ Test(utils_args, basic_file_input)
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    cr_expect(options.pretty_print == false);
+    // cr_expect(options.pretty_print == false);
     cr_expect(options.verbose == false);
     cr_expect(options.type == INPUT_FILE);
     cr_expect(eq(options.input_source, "input.txt"));
@@ -65,13 +67,15 @@ Test(utils_args, basic_file_input_with_flags)
 {
     int argc = 4;
     struct args_options options;
-    char *input[] = { "program", "--verbose", "input.txt", "--pretty-print" };
+    // char *input[] = { "program", "--verbose", "input.txt", "--pretty-print"
+    // };
+    char *input[] = { "program", "--verbose", "input.txt" };
 
     struct hash_map *vars = vars_init();
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    cr_expect(options.pretty_print == true);
+    // cr_expect(options.pretty_print == true);
     cr_expect(options.verbose == true);
     cr_expect(options.type == INPUT_FILE);
     cr_expect(eq(options.input_source, "input.txt"));
@@ -88,7 +92,7 @@ Test(utils_args, basic_stdin_input)
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    cr_expect(options.pretty_print == false);
+    // cr_expect(options.pretty_print == false);
     cr_expect(options.verbose == false);
     cr_expect(options.type == INPUT_STDIN);
     cr_expect(options.input_source == NULL);
@@ -99,13 +103,14 @@ Test(utils_args, pretty_print_and_verbose_flags)
 {
     int argc = 3;
     struct args_options options;
-    char *input[] = { "program", "--pretty-print", "--verbose" };
+    // char *input[] = { "program", "--pretty-print", "--verbose" };
+    char *input[] = { "program", "--verbose" };
 
     struct hash_map *vars = vars_init();
     int r = args_handler(argc, input, &options, vars);
 
     cr_expect(r == 0);
-    cr_expect(options.pretty_print == true);
+    // cr_expect(options.pretty_print == true);
     cr_expect(options.verbose == true);
     cr_expect(options.type == INPUT_STDIN);
     cr_expect(options.input_source == NULL);

tests/unit/utils/lists.c

@@ -0,0 +1,305 @@
+#define _POSIX_C_SOURCE 200809L
+
+#include "../../../src/utils/lists/lists.h"
+
+#include <criterion/criterion.h>
+#include <criterion/new/assert.h>
+#include <criterion/redirect.h>
+#include <stddef.h>
+#include <stdio.h>
+#include <string.h>
+#include <sys/types.h>
+
+TestSuite(lists);
+
+Test(lists, append_empty)
+{
+    struct list *lst = NULL;
+    lst = list_append(lst, (void *)1);
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)1);
+    cr_expect(lst->next == NULL);
+    cr_expect(list_length(lst) == 1);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, prepend_empty)
+{
+    struct list *lst = NULL;
+    lst = list_prepend(lst, (void *)1);
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)1);
+    cr_expect(lst->next == NULL);
+    cr_expect(list_length(lst) == 1);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, insert_empty)
+{
+    struct list *lst = NULL;
+    lst = list_insert(lst, (void *)1, 0);
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)1);
+    cr_expect(lst->next == NULL);
+    cr_expect(list_length(lst) == 1);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, insert_out_of_bounds)
+{
+    struct list *lst = NULL;
+    lst = list_insert(lst, (void *)1, 5);
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)1);
+    cr_expect(lst->next == NULL);
+    cr_expect(list_length(lst) == 1);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, remove_out_of_bounds)
+{
+    struct list *lst = NULL;
+    lst = list_append(lst, (void *)1);
+    lst = list_remove(lst, 5);
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)1);
+    cr_expect(lst->next == NULL);
+    cr_expect(list_length(lst) == 1);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, append_multiple)
+{
+    struct list *lst = NULL;
+    lst = list_append(lst, (void *)1);
+    lst = list_append(lst, (void *)2);
+    lst = list_append(lst, (void *)3);
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)1);
+    cr_expect(lst->next->data == (void *)2);
+    cr_expect(lst->next->next->data == (void *)3);
+    cr_expect(lst->next->next->next == NULL);
+    cr_expect(list_length(lst) == 3);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, prepend_multiple)
+{
+    struct list *lst = NULL;
+    lst = list_prepend(lst, (void *)1);
+    lst = list_prepend(lst, (void *)2);
+    lst = list_prepend(lst, (void *)3);
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)3);
+    cr_expect(lst->next->data == (void *)2);
+    cr_expect(lst->next->next->data == (void *)1);
+    cr_expect(lst->next->next->next == NULL);
+    cr_expect(list_length(lst) == 3);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, insert_multiple)
+{
+    struct list *lst = NULL;
+    lst = list_insert(lst, (void *)1, 0);
+    lst = list_insert(lst, (void *)3, 1);
+    lst = list_insert(lst, (void *)2, 1);
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)1);
+    cr_expect(lst->next->data == (void *)2);
+    cr_expect(lst->next->next->data == (void *)3);
+    cr_expect(lst->next->next->next == NULL);
+    cr_expect(list_length(lst) == 3);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, append)
+{
+    struct list *lst = NULL;
+    lst = list_prepend(lst, (void *)2);
+    lst = list_prepend(lst, (void *)1);
+
+    lst = list_append(lst, (void *)3);
+
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)1);
+    cr_expect(lst->next->data == (void *)2);
+    cr_expect(lst->next->next->data == (void *)3);
+    cr_expect(lst->next->next->next == NULL);
+    cr_expect(list_length(lst) == 3);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, prepend)
+{
+    struct list *lst = NULL;
+    lst = list_append(lst, (void *)1);
+    lst = list_append(lst, (void *)2);
+
+    lst = list_prepend(lst, (void *)0);
+
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)0);
+    cr_expect(lst->next->data == (void *)1);
+    cr_expect(lst->next->next->data == (void *)2);
+    cr_expect(lst->next->next->next == NULL);
+    cr_expect(list_length(lst) == 3);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, insert)
+{
+    struct list *lst = NULL;
+    lst = list_append(lst, (void *)1);
+    lst = list_append(lst, (void *)3);
+
+    lst = list_insert(lst, (void *)2, 1);
+    lst = list_insert(lst, (void *)0, 0);
+
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)0);
+    cr_expect(lst->next->data == (void *)1);
+    cr_expect(lst->next->next->data == (void *)2);
+    cr_expect(lst->next->next->next->data == (void *)3);
+    cr_expect(lst->next->next->next->next == NULL);
+    cr_expect(list_length(lst) == 4);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, remove)
+{
+    struct list *lst = NULL;
+    lst = list_append(lst, (void *)1);
+    lst = list_append(lst, (void *)2);
+    lst = list_append(lst, (void *)3);
+    lst = list_append(lst, (void *)4);
+
+    lst = list_remove(lst, 1); // remove 2
+    lst = list_remove(lst, 2); // remove 4
+    lst = list_remove(lst, 0); // remove 1
+
+    cr_expect(lst != NULL);
+    cr_expect(lst->data == (void *)3);
+    cr_expect(lst->next == NULL);
+    cr_expect(list_length(lst) == 1);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, destroy_null)
+{
+    struct list *lst = NULL;
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, deep_destroy_null)
+{
+    struct list *lst = NULL;
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, deep_destroy)
+{
+    struct list *lst = NULL;
+    lst = list_append(lst, strdup("string1"));
+    lst = list_append(lst, strdup("string2"));
+    lst = list_append(lst, strdup("string3"));
+
+    list_deep_destroy(lst);
+}
+
+Test(lists, length_empty)
+{
+    struct list *lst = NULL;
+    cr_expect(list_length(lst) == 0);
+}
+
+Test(lists, print_empty, .init = cr_redirect_stdout)
+{
+    struct list *lst = NULL;
+    list_print(lst);
+    cr_expect_stdout_eq_str("");
+}
+
+Test(lists, print_non_empty, .init = cr_redirect_stdout)
+{
+    struct list *lst = NULL;
+    lst = list_append(lst, (void *)1);
+    lst = list_append(lst, (void *)2);
+    lst = list_append(lst, (void *)3);
+
+    list_print(lst);
+    fflush(stdout);
+    cr_expect_stdout_eq_str("0x1 0x2 0x3\n");
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+Test(lists, find_empty)
+{
+    struct list *lst = NULL;
+    cr_expect(list_find(lst, (void *)1) == -1);
+}
+
+Test(lists, find_non_empty)
+{
+    struct list *lst = NULL;
+    lst = list_append(lst, (void *)1);
+    lst = list_append(lst, (void *)2);
+    lst = list_append(lst, (void *)3);
+
+    cr_expect(list_find(lst, (void *)1) == 0);
+    cr_expect(list_find(lst, (void *)2) == 1);
+    cr_expect(list_find(lst, (void *)3) == 2);
+    cr_expect(list_find(lst, (void *)4) == -1); // not found
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}
+
+static void fold_func(void *acc, void *data)
+{
+    *(int *)acc += *(int *)data;
+}
+
+Test(lists, fold)
+{
+    struct list *lst = NULL;
+    int v1 = 10, v2 = 20, v3 = 30;
+    lst = list_append(lst, &v1);
+    lst = list_append(lst, &v2);
+    lst = list_append(lst, &v3);
+
+    int sum = 0;
+    list_fold(lst, &sum, fold_func);
+    cr_expect(sum == 60);
+
+    list_destroy(&lst);
+    cr_expect(lst == NULL);
+}

tests/unit/utils/vars.c

@@ -0,0 +1,85 @@
+#define _POSIX_C_SOURCE 200809L
+#include "../../../src/utils/vars/vars.h"
+
+#include <criterion/criterion.h>
+#include <criterion/new/assert.h>
+#include <criterion/redirect.h>
+#include <stdio.h>
+#include <unistd.h>
+
+#include "../../../src/utils/hash_map/hash_map.h"
+#include "../../../src/utils/string_utils/string_utils.h"
+
+TestSuite(utils_vars);
+
+Test(utils_vars, init_free)
+{
+    struct hash_map *map = vars_init();
+    cr_expect_not_null(map);
+    hash_map_free(&map);
+}
+
+Test(utils_vars, get_defaults)
+{
+    struct hash_map *map = vars_init();
+    cr_expect_not_null(map);
+    cr_assert_str_eq(get_var(map, "?"), "0");
+    char int_str[11];
+    int_to_str((int)getpid(), int_str);
+    cr_assert_str_eq(get_var(map, "$"), int_str);
+    int_to_str((int)getuid(), int_str);
+    cr_assert_str_eq(get_var(map, "UID"), int_str);
+
+    hash_map_free(&map);
+}
+
+Test(utils_vars, set_vars)
+{
+    struct hash_map *map = vars_init();
+    cr_expect_not_null(map);
+    set_var_copy(map, "key1", "value1");
+    cr_assert_str_eq(get_var(map, "key1"), "value1");
+    set_var_copy(map, "key2", "value2");
+    cr_assert_str_eq(get_var(map, "key2"), "value2");
+
+    hash_map_free(&map);
+}
+
+Test(utils_vars, get_env_vars)
+{
+    struct hash_map *map = vars_init();
+    cr_expect_not_null(map);
+    cr_assert_eq(get_var_or_env(map, "ENV_TEST"), NULL);
+    setenv("ENV_TEST", "value1", 0);
+    cr_assert_str_eq(get_var_or_env(map, "ENV_TEST"), "value1");
+    setenv("ENV_TEST", "value2", 1);
+    cr_assert_str_eq(get_var_or_env(map, "ENV_TEST"), "value2");
+
+    hash_map_free(&map);
+}
+
+Test(utils_vars, set_vars_update)
+{
+    struct hash_map *map = vars_init();
+    cr_expect_not_null(map);
+    set_var_copy(map, "key", "value1");
+    cr_assert_str_eq(get_var(map, "key"), "value1");
+    set_var_copy(map, "key", "value2");
+    cr_assert_str_eq(get_var(map, "key"), "value2");
+
+    hash_map_free(&map);
+}
+
+Test(utils_vars, set_vars_int)
+{
+    struct hash_map *map = vars_init();
+    cr_expect_not_null(map);
+    set_var_int(map, "key1", 100);
+    cr_assert_str_eq(get_var(map, "key1"), "100");
+    set_var_int(map, "key1", 200);
+    cr_assert_str_eq(get_var(map, "key1"), "200");
+    set_var_int(map, "key2", 10);
+    cr_assert_str_eq(get_var(map, "key2"), "10");
+
+    hash_map_free(&map);
+}